GNU bug report logs - #64155
[PATCH] gnu: emacs-piem: Update to 0.5.0.

Previous Next

Package: guix-patches;

Reported by: jlicht <at> fsfe.org

Date: Sun, 18 Jun 2023 19:39:01 UTC

Severity: normal

Tags: patch

Done: Jelle Licht <jlicht <at> fsfe.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Andrew Tropin <andrew <at> trop.in>
To: jlicht <at> fsfe.org, 64155 <at> debbugs.gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>, Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 17:44:45 +0400
[Message part 1 (text/plain, inline)]
On 2023-06-18 21:38, jlicht <at> fsfe.org wrote:

> From: Jelle Licht <jlicht <at> fsfe.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
> [propagated-inputs]: Add emacs-debbugs.
> ---
>
>  gnu/packages/emacs-xyz.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index f46af73aec..08ec87b94c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>  (define-public emacs-piem
>    (package
>      (name "emacs-piem")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>               (commit (string-append "v" version))))
>         (file-name (string-append name "-" version "-checkout"))
>         (sha256
> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:phases
> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>      (inputs
>       (list b4))
>      (propagated-inputs
> -     (list emacs-elfeed
> +     (list emacs-debbugs
> +           emacs-elfeed
>             emacs-notmuch))
>      (home-page "https://docs.kyleam.com/piem")
>      (synopsis "Glue for working with public-inbox archives")
>
> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e

Hi Jelle!

Thank you very much for the patch.

IMHO, optional dependencies should not be propagated.  On user side
installing additional packages is easier than transforming existing
package and removing unneeded propagated deps.  Personally, I would
remove all the propagated inputs from piem and let the user install what
he needs for his particular use case.

Liliana, Jelle WDYT?

-- 
Best regards,
Andrew Tropin
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 2 years and 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.