GNU bug report logs - #64155
[PATCH] gnu: emacs-piem: Update to 0.5.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64155 in the body.
You can then email your comments to 64155 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jlicht <at> fsfe.org
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Sun, 18 Jun 2023 21:38:06 +0200

From: Jelle Licht <jlicht <at> fsfe.org>

* gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
[propagated-inputs]: Add emacs-debbugs.
---

 gnu/packages/emacs-xyz.scm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f46af73aec..08ec87b94c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
 (define-public emacs-piem
   (package
     (name "emacs-piem")
-    (version "0.4.0")
+    (version "0.5.0")
     (source
      (origin
        (method git-fetch)
@@ -8346,7 +8346,7 @@ (define-public emacs-piem
              (commit (string-append "v" version))))
        (file-name (string-append name "-" version "-checkout"))
        (sha256
-        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
+        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
     (build-system emacs-build-system)
     (arguments
      (list #:phases
@@ -8359,7 +8359,8 @@ (define-public emacs-piem
     (inputs
      (list b4))
     (propagated-inputs
-     (list emacs-elfeed
+     (list emacs-debbugs
+           emacs-elfeed
            emacs-notmuch))
     (home-page "https://docs.kyleam.com/piem")
     (synopsis "Glue for working with public-inbox archives")

base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e
-- 
2.40.1

Message #8 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: jlicht <at> fsfe.org, 64155 <at> debbugs.gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 17:44:45 +0400

[Message part 1 (text/plain, inline)]

On 2023-06-18 21:38, jlicht <at> fsfe.org wrote:

> From: Jelle Licht <jlicht <at> fsfe.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
> [propagated-inputs]: Add emacs-debbugs.
> ---
>
>  gnu/packages/emacs-xyz.scm | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index f46af73aec..08ec87b94c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>  (define-public emacs-piem
>    (package
>      (name "emacs-piem")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>               (commit (string-append "v" version))))
>         (file-name (string-append name "-" version "-checkout"))
>         (sha256
> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:phases
> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>      (inputs
>       (list b4))
>      (propagated-inputs
> -     (list emacs-elfeed
> +     (list emacs-debbugs
> +           emacs-elfeed
>             emacs-notmuch))
>      (home-page "https://docs.kyleam.com/piem")
>      (synopsis "Glue for working with public-inbox archives")
>
> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e

Hi Jelle!

Thank you very much for the patch.

IMHO, optional dependencies should not be propagated.  On user side
installing additional packages is easier than transforming existing
package and removing unneeded propagated deps.  Personally, I would
remove all the propagated inputs from piem and let the user install what
he needs for his particular use case.

Liliana, Jelle WDYT?

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Andrew Tropin <andrew <at> trop.in>, 64155 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 17:39:48 +0200

Hi Andrew + peanut gallery,

Andrew Tropin <andrew <at> trop.in> writes:

> On 2023-06-18 21:38, jlicht <at> fsfe.org wrote:
>
>> From: Jelle Licht <jlicht <at> fsfe.org>
>>
>> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
>> [propagated-inputs]: Add emacs-debbugs.
>> ---
>>
>>  gnu/packages/emacs-xyz.scm | 7 ++++---
>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index f46af73aec..08ec87b94c 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>>  (define-public emacs-piem
>>    (package
>>      (name "emacs-piem")
>> -    (version "0.4.0")
>> +    (version "0.5.0")
>>      (source
>>       (origin
>>         (method git-fetch)
>> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>>               (commit (string-append "v" version))))
>>         (file-name (string-append name "-" version "-checkout"))
>>         (sha256
>> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
>> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>>      (build-system emacs-build-system)
>>      (arguments
>>       (list #:phases
>> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>>      (inputs
>>       (list b4))
>>      (propagated-inputs
>> -     (list emacs-elfeed
>> +     (list emacs-debbugs
>> +           emacs-elfeed
>>             emacs-notmuch))
>>      (home-page "https://docs.kyleam.com/piem")
>>      (synopsis "Glue for working with public-inbox archives")
>>
>> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e
>
> Hi Jelle!
>
> Thank you very much for the patch.
>
> IMHO, optional dependencies should not be propagated.  On user side
> installing additional packages is easier than transforming existing
> package and removing unneeded propagated deps.  Personally, I would
> remove all the propagated inputs from piem and let the user install what
> he needs for his particular use case.

I'm of two minds, both for this particular patch, and the policy in
general. I understand the point you are making, and see the elegance of
offering a clean set of composable parts for users (and downstream) to
compose.

OTOH, it makes getting full-featured (and compiled) packages a chore,
where users or downstream has to pick up the slack. Put another
way; someone somewhere has to make a package variant if you want to
cover all use cases.

It is my understanding the guideline is (/was?) to have packages be
full-featured, and offer a '-minimal' version in cases where it makes
sense (e.g. bootstrapping, less-than-sane dependency graphs). If this
guideline has since changed, or (in this case) the Emacs teams decides
otherwise, that is something I'm obviously fine with. Some practical
tips on how to make byte compilation happen would still be appreciated
in that case :-).

All the best,
- Jelle

Message #14 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Jelle Licht <jlicht <at> fsfe.org>, 64155 <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 20:32:58 +0400

[Message part 1 (text/plain, inline)]

On 2023-06-19 17:39, Jelle Licht wrote:

> Hi Andrew + peanut gallery,
>
> Andrew Tropin <andrew <at> trop.in> writes:
>
>> On 2023-06-18 21:38, jlicht <at> fsfe.org wrote:
>>
>>> From: Jelle Licht <jlicht <at> fsfe.org>
>>>
>>> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
>>> [propagated-inputs]: Add emacs-debbugs.
>>> ---
>>>
>>>  gnu/packages/emacs-xyz.scm | 7 ++++---
>>>  1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>>> index f46af73aec..08ec87b94c 100644
>>> --- a/gnu/packages/emacs-xyz.scm
>>> +++ b/gnu/packages/emacs-xyz.scm
>>> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>>>  (define-public emacs-piem
>>>    (package
>>>      (name "emacs-piem")
>>> -    (version "0.4.0")
>>> +    (version "0.5.0")
>>>      (source
>>>       (origin
>>>         (method git-fetch)
>>> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>>>               (commit (string-append "v" version))))
>>>         (file-name (string-append name "-" version "-checkout"))
>>>         (sha256
>>> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
>>> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>>>      (build-system emacs-build-system)
>>>      (arguments
>>>       (list #:phases
>>> @@ -8359,7 +8359,8 @@ (define-public emacs-piem
>>>      (inputs
>>>       (list b4))
>>>      (propagated-inputs
>>> -     (list emacs-elfeed
>>> +     (list emacs-debbugs
>>> +           emacs-elfeed
>>>             emacs-notmuch))
>>>      (home-page "https://docs.kyleam.com/piem")
>>>      (synopsis "Glue for working with public-inbox archives")
>>>
>>> base-commit: 726f2a944730a1edbdbebfe57fb9e7e0ba47d83e
>>
>> Hi Jelle!
>>
>> Thank you very much for the patch.
>>
>> IMHO, optional dependencies should not be propagated.  On user side
>> installing additional packages is easier than transforming existing
>> package and removing unneeded propagated deps.  Personally, I would
>> remove all the propagated inputs from piem and let the user install what
>> he needs for his particular use case.
>
> I'm of two minds, both for this particular patch, and the policy in
> general. I understand the point you are making, and see the elegance of
> offering a clean set of composable parts for users (and downstream) to
> compose.
>
> OTOH, it makes getting full-featured (and compiled) packages a chore,
> where users or downstream has to pick up the slack. Put another
> way; someone somewhere has to make a package variant if you want to
> cover all use cases.
>
> It is my understanding the guideline is (/was?) to have packages be
> full-featured, and offer a '-minimal' version in cases where it makes
> sense (e.g. bootstrapping, less-than-sane dependency graphs). If this
> guideline has since changed, or (in this case) the Emacs teams decides
> otherwise, that is something I'm obviously fine with. Some practical
> tips on how to make byte compilation happen would still be appreciated
> in that case :-).

I think we can do byte/native compilation without propagating deps, so
it's almost ready to consume, but doesn't pollute the profile.

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Andrew Tropin <andrew <at> trop.in>, jlicht <at> fsfe.org, 64155 <at> debbugs.gnu.org
Subject: Re: [bug#64155] [PATCH] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 20:24:13 +0200

Am Montag, dem 19.06.2023 um 17:44 +0400 schrieb Andrew Tropin:
> Hi Jelle!
> 
> Thank you very much for the patch.
> 
> IMHO, optional dependencies should not be propagated.  On user side
> installing additional packages is easier than transforming existing
> package and removing unneeded propagated deps.  Personally, I would
> remove all the propagated inputs from piem and let the user install
> what he needs for his particular use case.
> 
> Liliana, Jelle WDYT?
s/he needs/they need/

Other than that, I don't really have an opinion, but at the very least
we don't *have* to propagate debbugs, given that users who want to use
that probably already have it.  As for why I don't really have an
opinion: I don't know how central the existing propagations are towards
the working of emacs-piem.

That being said, we could always make those inputs regular (which might
be helpful for byte/native-compilation).

Cheers

Message #20 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: jlicht <at> fsfe.org
To: 64155 <at> debbugs.gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: [PATCH v2 1/2] gnu: emacs-piem: Do not propagate any inputs.
Date: Mon, 19 Jun 2023 21:35:53 +0200

From: Jelle Licht <jlicht <at> fsfe.org>

* gnu/packages/emacs-xyz.scm (emacs-piem) [propagated-inputs]: Remove, moving
emacs-elfeed and emacs-notmuch to...
[inputs]: ...here.
---

(no changes since v1)

 gnu/packages/emacs-xyz.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f46af73aec..416656f243 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8357,9 +8357,8 @@ (define-public emacs-piem
                      ("piem-b4-b4-executable"
                       (search-input-file inputs "/bin/b4"))))))))
     (inputs
-     (list b4))
-    (propagated-inputs
-     (list emacs-elfeed
+     (list b4
+           emacs-elfeed
            emacs-notmuch))
     (home-page "https://docs.kyleam.com/piem")
     (synopsis "Glue for working with public-inbox archives")

base-commit: d884fc9e2efecfba09af4694f5a13ad7fc6f704f
-- 
2.40.1

Message #23 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: jlicht <at> fsfe.org
To: 64155 <at> debbugs.gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0.
Date: Mon, 19 Jun 2023 21:35:54 +0200

From: Jelle Licht <jlicht <at> fsfe.org>

* gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
[inputs]: Add emacs-debbugs.

---

(no changes since v1)

 gnu/packages/emacs-xyz.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 416656f243..08d53be8a9 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
 (define-public emacs-piem
   (package
     (name "emacs-piem")
-    (version "0.4.0")
+    (version "0.5.0")
     (source
      (origin
        (method git-fetch)
@@ -8346,7 +8346,7 @@ (define-public emacs-piem
              (commit (string-append "v" version))))
        (file-name (string-append name "-" version "-checkout"))
        (sha256
-        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
+        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
     (build-system emacs-build-system)
     (arguments
      (list #:phases
@@ -8358,6 +8358,7 @@ (define-public emacs-piem
                       (search-input-file inputs "/bin/b4"))))))))
     (inputs
      (list b4
+           emacs-debbugs
            emacs-elfeed
            emacs-notmuch))
     (home-page "https://docs.kyleam.com/piem")
-- 
2.40.1

Message #26 received at 64155 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: jlicht <at> fsfe.org, 64155 <at> debbugs.gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0.
Date: Tue, 20 Jun 2023 07:23:34 +0400

[Message part 1 (text/plain, inline)]

On 2023-06-19 21:35, jlicht <at> fsfe.org wrote:

> From: Jelle Licht <jlicht <at> fsfe.org>
>
> * gnu/packages/emacs-xyz.scm (emacs-piem): Update to 0.5.0.
> [inputs]: Add emacs-debbugs.
>
> ---
>
> (no changes since v1)
>
>  gnu/packages/emacs-xyz.scm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 416656f243..08d53be8a9 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8337,7 +8337,7 @@ (define-public emacs-debbugs
>  (define-public emacs-piem
>    (package
>      (name "emacs-piem")
> -    (version "0.4.0")
> +    (version "0.5.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -8346,7 +8346,7 @@ (define-public emacs-piem
>               (commit (string-append "v" version))))
>         (file-name (string-append name "-" version "-checkout"))
>         (sha256
> -        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +        (base32 "0smdb1iph2q1xvxix5c93llckcxh7kmhg6pxgyrm88j736m4l16q"))))
>      (build-system emacs-build-system)
>      (arguments
>       (list #:phases
> @@ -8358,6 +8358,7 @@ (define-public emacs-piem
>                        (search-input-file inputs "/bin/b4"))))))))
>      (inputs
>       (list b4
> +           emacs-debbugs
>             emacs-elfeed
>             emacs-notmuch))
>      (home-page "https://docs.kyleam.com/piem")

It looks good to me!

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 64155-done <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Andrew Tropin <andrew <at> trop.in>, 64155-done <at> debbugs.gnu.org
Cc: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Subject: Re: [PATCH v2 2/2] gnu: emacs-piem: Update to 0.5.0.
Date: Tue, 20 Jun 2023 21:10:38 +0200

Andrew Tropin <andrew <at> trop.in> writes:

> It looks good to me!

Pushed to master, thanks for the reviews!
- Jelle

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.