GNU bug report logs - #63867
29.0.91; typescript-ts-mode does not highlight function signature overloads

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63867: closed (29.0.91; typescript-ts-mode does not highlight
 function signature overloads)
Date: Sat, 03 Jun 2023 12:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 3 Jun 2023 15:01:28 +0300
with message-id <213224c6-5d92-f16c-b542-a827935917b3 <at> gutov.dev>
and subject line Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight function signature overloads
has caused the debbugs.gnu.org bug report #63867,
regarding 29.0.91; typescript-ts-mode does not highlight function signature overloads
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63867: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63867
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.91; typescript-ts-mode does not highlight function signature
 overloads
Date: Sat, 03 Jun 2023 10:37:07 +0100

Reproduction:

1. C-x C-f test.ts
2. Insert:

```typescript
function fn():void;
function fn(arg1?:number, arg2?:string):void {
}
```

3. Observe the fn in the overload signature isn't highlighted as a
function name

Expectation:

Function signature overloads should highlight the function names.

[Message part 3 (message/rfc822, inline)]

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>,
 Theodor Thornhill <theo <at> thornhill.no>, Yuan Fu <casouri <at> gmail.com>
Cc: 63867-done <at> debbugs.gnu.org
Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight
 function signature overloads
Date: Sat, 3 Jun 2023 15:01:28 +0300

On 03/06/2023 12:47, Eli Zaretskii wrote:
>> From: Jimmy Yuen Ho Wong<wyuenho <at> gmail.com>
>> Date: Sat, 03 Jun 2023 10:37:07 +0100
>>
>>
>> Reproduction:
>>
>> 1. C-x C-f test.ts
>> 2. Insert:
>>
>> ```typescript
>> function fn():void;
>> function fn(arg1?:number, arg2?:string):void {
>> }
>> ```
>>
>> 3. Observe the fn in the overload signature isn't highlighted as a
>> function name
>>
>> Expectation:
>>
>> Function signature overloads should highlight the function names.
> Thanks.
> 
> Guys, could you please look into fixing this?

I've pushed a fix to emacs-29, rev 583ba1db7ee.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.