GNU bug report logs - #63867
29.0.91; typescript-ts-mode does not highlight function signature overloads

Previous Next

Package: emacs;

Reported by: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>

Date: Sat, 3 Jun 2023 09:38:02 UTC

Severity: normal

Found in version 29.0.91

Done: Dmitry Gutov <dmitry <at> gutov.dev>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63867 in the body.
You can then email your comments to 63867 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#63867; Package emacs. (Sat, 03 Jun 2023 09:38:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sat, 03 Jun 2023 09:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.91; typescript-ts-mode does not highlight function signature
 overloads
Date: Sat, 03 Jun 2023 10:37:07 +0100

Reproduction:

1. C-x C-f test.ts
2. Insert:

```typescript
function fn():void;
function fn(arg1?:number, arg2?:string):void {
}
```

3. Observe the fn in the overload signature isn't highlighted as a
function name

Expectation:

Function signature overloads should highlight the function names.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63867; Package emacs. (Sat, 03 Jun 2023 09:47:02 GMT) Full text and rfc822 format available.

Message #8 received at 63867 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>,
 Theodor Thornhill <theo <at> thornhill.no>, Yuan Fu <casouri <at> gmail.com>
Cc: 63867 <at> debbugs.gnu.org
Subject: Re: bug#63867: 29.0.91;
 typescript-ts-mode does not highlight function signature overloads
Date: Sat, 03 Jun 2023 12:47:25 +0300

> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> Date: Sat, 03 Jun 2023 10:37:07 +0100
> 
> 
> Reproduction:
> 
> 1. C-x C-f test.ts
> 2. Insert:
> 
> ```typescript
> function fn():void;
> function fn(arg1?:number, arg2?:string):void {
> }
> ```
> 
> 3. Observe the fn in the overload signature isn't highlighted as a
> function name
> 
> Expectation:
> 
> Function signature overloads should highlight the function names.

Thanks.

Guys, could you please look into fixing this?
Reply sent to Dmitry Gutov <dmitry <at> gutov.dev>:
You have taken responsibility. (Sat, 03 Jun 2023 12:02:01 GMT) Full text and rfc822 format available.
Notification sent to Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>:
bug acknowledged by developer. (Sat, 03 Jun 2023 12:02:02 GMT) Full text and rfc822 format available.

Message #13 received at 63867-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>,
 Theodor Thornhill <theo <at> thornhill.no>, Yuan Fu <casouri <at> gmail.com>
Cc: 63867-done <at> debbugs.gnu.org
Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight
 function signature overloads
Date: Sat, 3 Jun 2023 15:01:28 +0300

On 03/06/2023 12:47, Eli Zaretskii wrote:
>> From: Jimmy Yuen Ho Wong<wyuenho <at> gmail.com>
>> Date: Sat, 03 Jun 2023 10:37:07 +0100
>>
>>
>> Reproduction:
>>
>> 1. C-x C-f test.ts
>> 2. Insert:
>>
>> ```typescript
>> function fn():void;
>> function fn(arg1?:number, arg2?:string):void {
>> }
>> ```
>>
>> 3. Observe the fn in the overload signature isn't highlighted as a
>> function name
>>
>> Expectation:
>>
>> Function signature overloads should highlight the function names.
> Thanks.
> 
> Guys, could you please look into fixing this?

I've pushed a fix to emacs-29, rev 583ba1db7ee.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#63867; Package emacs. (Sat, 03 Jun 2023 12:20:01 GMT) Full text and rfc822 format available.

Message #16 received at 63867-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: theo <at> thornhill.no, casouri <at> gmail.com, jostein <at> kjonigsen.net,
 wyuenho <at> gmail.com, 63867-done <at> debbugs.gnu.org
Subject: Re: bug#63867: 29.0.91; typescript-ts-mode does not highlight
 function signature overloads
Date: Sat, 03 Jun 2023 15:20:13 +0300

> Date: Sat, 3 Jun 2023 15:01:28 +0300
> Cc: 63867-done <at> debbugs.gnu.org
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 03/06/2023 12:47, Eli Zaretskii wrote:
> >> From: Jimmy Yuen Ho Wong<wyuenho <at> gmail.com>
> >> Date: Sat, 03 Jun 2023 10:37:07 +0100
> >>
> >>
> >> Reproduction:
> >>
> >> 1. C-x C-f test.ts
> >> 2. Insert:
> >>
> >> ```typescript
> >> function fn():void;
> >> function fn(arg1?:number, arg2?:string):void {
> >> }
> >> ```
> >>
> >> 3. Observe the fn in the overload signature isn't highlighted as a
> >> function name
> >>
> >> Expectation:
> >>
> >> Function signature overloads should highlight the function names.
> > Thanks.
> > 
> > Guys, could you please look into fixing this?
> 
> I've pushed a fix to emacs-29, rev 583ba1db7ee.

Thanks.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 02 Jul 2023 11:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 353 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.