GNU bug report logs - #63810
29.0.91; typescript-ts-mode grammar missing the "is" keyword

Previous Next

Package: emacs;

Reported by: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>

Date: Wed, 31 May 2023 07:31:02 UTC

Severity: normal

Found in version 29.0.91

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#63810: closed (29.0.91; typescript-ts-mode grammar missing
 the "is" keyword)
Date: Thu, 01 Jun 2023 11:59:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 01 Jun 2023 14:58:48 +0300
with message-id <83fs7bcs1z.fsf <at> gnu.org>
and subject line Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
has caused the debbugs.gnu.org bug report #63810,
regarding 29.0.91; typescript-ts-mode grammar missing the "is" keyword
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
63810: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63810
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
Date: Wed, 31 May 2023 08:30:14 +0100
Reproduction:

1. C-x C-f test.ts
2. Insert
   ```typescript
   function isFish(pet: Fish | Bird): pet is Fish {
     return (pet as Fish).swim !== undefined;
   }
   ```
3. Observe the `is` keyword isn't highlighted.

Expectation:

TypeScript has a concept called type predicates, which introduces a
keyword called `is`.


[Reference](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates)


[Message part 3 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 63810-done <at> debbugs.gnu.org, casouri <at> gmail.com, jostein <at> kjonigsen.net,
 wyuenho <at> gmail.com
Subject: Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is"
 keyword
Date: Thu, 01 Jun 2023 14:58:48 +0300
> From: Theodor Thornhill <theo <at> thornhill.no>
> Cc: 63810 <at> debbugs.gnu.org
> Date: Wed, 31 May 2023 20:51:59 +0200
> 
> Now fixed on emacs-29.

Thanks, closing.


This bug report was last modified 1 year and 355 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.