GNU bug report logs - #63810
29.0.91; typescript-ts-mode grammar missing the "is" keyword

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 63810 in the body.
You can then email your comments to 63810 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
Date: Wed, 31 May 2023 08:30:14 +0100

Reproduction:

1. C-x C-f test.ts
2. Insert
   ```typescript
   function isFish(pet: Fish | Bird): pet is Fish {
     return (pet as Fish).swim !== undefined;
   }
   ```
3. Observe the `is` keyword isn't highlighted.

Expectation:

TypeScript has a concept called type predicates, which introduces a
keyword called `is`.


[Reference](https://www.typescriptlang.org/docs/handbook/2/narrowing.html#using-type-predicates)

Message #8 received at 63810 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Theodor Thornhill <theo <at> thornhill.no>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>
Cc: 63810 <at> debbugs.gnu.org
Subject: Re: bug#63810: 29.0.91;
 typescript-ts-mode grammar missing the "is" keyword
Date: Wed, 31 May 2023 15:21:50 +0300

> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
> Date: Wed, 31 May 2023 08:30:14 +0100
> 
> 1. C-x C-f test.ts
> 2. Insert
>    ```typescript
>    function isFish(pet: Fish | Bird): pet is Fish {
>      return (pet as Fish).swim !== undefined;
>    }
>    ```
> 3. Observe the `is` keyword isn't highlighted.
> 
> Expectation:
> 
> TypeScript has a concept called type predicates, which introduces a
> keyword called `is`.

Thanks.

Can you guys please look into this?

Message #11 received at 63810 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>
Cc: 63810 <at> debbugs.gnu.org
Subject: Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is" keyword
Date: Wed, 31 May 2023 15:20:00 +0200

On 31 May 2023 14:21:50 CEST, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
>> Date: Wed, 31 May 2023 08:30:14 +0100
>> 
>> 1. C-x C-f test.ts
>> 2. Insert
>>    ```typescript
>>    function isFish(pet: Fish | Bird): pet is Fish {
>>      return (pet as Fish).swim !== undefined;
>>    }
>>    ```
>> 3. Observe the `is` keyword isn't highlighted.
>> 
>> Expectation:
>> 
>> TypeScript has a concept called type predicates, which introduces a
>> keyword called `is`.
>
>Thanks.
>
>Can you guys please look into this?

Thanks for the ping. Will look into it this evening.

Theo

Message #14 received at 63810 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>, Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>,
 Jostein Kjonigsen <jostein <at> kjonigsen.net>, Yuan Fu <casouri <at> gmail.com>
Cc: 63810 <at> debbugs.gnu.org
Subject: Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is"
 keyword
Date: Wed, 31 May 2023 20:51:59 +0200

Theodor Thornhill <theo <at> thornhill.no> writes:

> On 31 May 2023 14:21:50 CEST, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>> From: Jimmy Yuen Ho Wong <wyuenho <at> gmail.com>
>>> Date: Wed, 31 May 2023 08:30:14 +0100
>>> 
>>> 1. C-x C-f test.ts
>>> 2. Insert
>>>    ```typescript
>>>    function isFish(pet: Fish | Bird): pet is Fish {
>>>      return (pet as Fish).swim !== undefined;
>>>    }
>>>    ```
>>> 3. Observe the `is` keyword isn't highlighted.
>>> 
>>> Expectation:
>>> 
>>> TypeScript has a concept called type predicates, which introduces a
>>> keyword called `is`.
>>
>>Thanks.
>>
>>Can you guys please look into this?
>
> Thanks for the ping. Will look into it this evening.
>
> Theo


Now fixed on emacs-29.

Thanks again for the ping :)

Theo

Message #19 received at 63810-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 63810-done <at> debbugs.gnu.org, casouri <at> gmail.com, jostein <at> kjonigsen.net,
 wyuenho <at> gmail.com
Subject: Re: bug#63810: 29.0.91; typescript-ts-mode grammar missing the "is"
 keyword
Date: Thu, 01 Jun 2023 14:58:48 +0300

> From: Theodor Thornhill <theo <at> thornhill.no>
> Cc: 63810 <at> debbugs.gnu.org
> Date: Wed, 31 May 2023 20:51:59 +0200
> 
> Now fixed on emacs-29.

Thanks, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.