GNU bug report logs - #63800
30.0.50; [ELPA] Inaccurate installation instructions for built-in packages

Previous Next

Full log

Message #41 received at 63800 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 63800 <at> debbugs.gnu.org
Subject: Re: bug#63800: 30.0.50; [ELPA] Inaccurate installation instructions
 for built-in packages
Date: Wed, 12 Jul 2023 07:46:07 +0000

Ihor Radchenko <yantar92 <at> posteo.net> writes:

> Dmitry Gutov <dmitry <at> gutov.dev> writes:
>
>> Perhaps a simpler alternative is to stop referencing 'package-install' 
>> and instead point uses to 'M-x list-packages'.
>
> See the attached patch.

Looks good, just one nitpick:

> From e3e7eae381c0756b54935121c3f0a641685af666 Mon Sep 17 00:00:00 2001
> Message-ID: <e3e7eae381c0756b54935121c3f0a641685af666.1688903858.git.yantar92 <at> posteo.net>
> From: Ihor Radchenko <yantar92 <at> posteo.net>
> Date: Sun, 9 Jul 2023 14:56:22 +0300
> Subject: [PATCH] Suggest `package-install' to install packages
>
> * elpa-admin.el (elpaa--html-make-pkg): Instruct using `list-packages'
> to install packages instead of `package-install'.
>
> See bug#63800.
> ---
>  elpa-admin.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/elpa-admin.el b/elpa-admin.el
> index 7ee385d0a..2b5c9b3dd 100644
> --- a/elpa-admin.el
> +++ b/elpa-admin.el
> @@ -1879,7 +1879,8 @@ (defun elpaa--html-make-pkg (pkg pkg-spec files srcdir plain-readme)
>        (elpaa--html-insert-docs pkg-spec)
>        (insert "</dl>")
>        (insert (format "<p>To install this package, run in Emacs:</p>
> -                       <pre>M-x <span class=\"kw\">package-install</span> RET <span class=\"kw\">%s</span> RET</pre>"
> +                       <pre>M-x <span class=\"kw\">list-packages</span> RET</pre>
> +                       <p>Then, find <span class=\"kw\">%s</span> in the list, click on the link, and click <span class=\"kw\">Install</span>.</p>"

Are you sure that "Install" should have the class kw (I assume keyword)?

>                        name))
>        (let* ((readme-content (elpaa--get-README pkg-spec srcdir))
>               (readme-text plain-readme)
> -- 
> 2.41.0

Other than that, can you push the commit or should I do it?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.