GNU bug report logs - #6366
join can't join on numeric fields

Previous Next

Full log

Message #27 received at 6366 <at> debbugs.gnu.org (full text, mbox):

From: Drew Frank <ajfrank <at> ics.uci.edu>
To: 6366 <at> debbugs.gnu.org
Subject: join can't join on numeric fields
Date: Tue, 20 Mar 2012 22:34:38 -0700

[Message part 1 (text/plain, inline)]

Hi,

I've attached a patch that implements both "numeric sort" (-n) and "general
numeric sort" (-g).. I copied the relevant comparison code from sort.c to
ensure consistent behavior. Should these functions be extracted and put in
a shared header file, or is it okay to duplicate the code?

In terms of testing, I confirmed that the code correctly deals with
different single-byte thousand separators on my local machine, but I wasn't
sure how to exercise that in the test suite since I can't rely on everyone
having a particular locale available. How should that be handled?

I also updated the relevant docs.

Thanks,
Drew

P.S. I sent a previous version of the patch to the wrong address and
accidentally initiated a new bug thread (#10924). This patch supersedes the
previous.

[Message part 2 (text/html, inline)]

[join.numeric.sort.diff (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.