GNU bug report logs - #6365
bidi data structure inefficiencies

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6365 in the body.
You can then email your comments to 6365 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: bidi data structure inefficiencies
Date: Sun, 06 Jun 2010 23:21:32 -0400

Some bidi data structures are bigger that they need to be, this
probably results in additional cache misses.
Examples:

struct bidi_saved_info could  use bitfields for the bidi_type_t members
Same for bidi_stack

bidi_it could use bitfields for a lot of it's members.

Message #6 received at 6365 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 6365 <at> debbugs.gnu.org
Subject: Re: bug#6365: bidi data structure inefficiencies
Date: Mon, 07 Jun 2010 09:37:02 -0400

> From: Dan Nicolaescu <dann <at> gnu.org>
> Date: Sun, 06 Jun 2010 23:21:32 -0400
> Cc: 
> 
> Some bidi data structures are bigger that they need to be, this
> probably results in additional cache misses.
> Examples:
> 
> struct bidi_saved_info could  use bitfields for the bidi_type_t members
> Same for bidi_stack
> 
> bidi_it could use bitfields for a lot of it's members.

Thanks for the critical review and suggestions.  I started a
discussion thread on emacs-devel about this, because I'm not sure
fixing this is a straight-forward matter.  I will implement whatever
conclusions are reached there as part of solving this bug report.

Message #9 received at 6365 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 6365 <at> debbugs.gnu.org
Subject: Re: bug#6365: bidi data structure inefficiencies
Date: Thu, 06 Oct 2011 16:51:50 -0400

Eli Zaretskii wrote:

> Thanks for the critical review and suggestions.  I started a
> discussion thread on emacs-devel about this, because I'm not sure
> fixing this is a straight-forward matter.  I will implement whatever
> conclusions are reached there as part of solving this bug report.

Did anything happen with this?

Message #12 received at 6365 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 6365 <at> debbugs.gnu.org
Subject: Re: bug#6365: bidi data structure inefficiencies
Date: Thu, 06 Oct 2011 23:04:54 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: 6365 <at> debbugs.gnu.org
> Date: Thu, 06 Oct 2011 16:51:50 -0400
> 
> Eli Zaretskii wrote:
> 
> > Thanks for the critical review and suggestions.  I started a
> > discussion thread on emacs-devel about this, because I'm not sure
> > fixing this is a straight-forward matter.  I will implement whatever
> > conclusions are reached there as part of solving this bug report.
> 
> Did anything happen with this?

See the discussion that started here:

  https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00164.html

AFAIU, the conclusion was that there are no evident optimizations, and
that only profiling the current code against an alternative can tell
which one is better.

FWIW, I don't plan working o this any time soon.

Message #15 received at 6365 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: rgm <at> gnu.org
Cc: 6365 <at> debbugs.gnu.org
Subject: Re: bug#6365: bidi data structure inefficiencies
Date: Thu, 06 Oct 2011 23:13:21 +0200

> Date: Thu, 06 Oct 2011 23:04:54 +0200
> From: Eli Zaretskii <eliz <at> gnu.org>
> Cc: 6365 <at> debbugs.gnu.org
> 
>   https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00164.html
> 
> AFAIU, the conclusion was that there are no evident optimizations, and
> that only profiling the current code against an alternative can tell
> which one is better.
> 
> FWIW, I don't plan working o this any time soon.

Oh, and I did convert 2 members of `struct bidi_it' from `int's to
1-bit fields.

Message #20 received at 6365-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 6365-done <at> debbugs.gnu.org
Subject: Re: bug#6365: bidi data structure inefficiencies
Date: Thu, 06 Oct 2011 17:22:40 -0400

Eli Zaretskii wrote:

>>   https://lists.gnu.org/archive/html/emacs-devel/2010-06/msg00164.html
>> 
>> AFAIU, the conclusion was that there are no evident optimizations, and
>> that only profiling the current code against an alternative can tell
>> which one is better.
>> 
>> FWIW, I don't plan working o this any time soon.
>
> Oh, and I did convert 2 members of `struct bidi_it' from `int's to
> 1-bit fields.

OK; doesn't seem worth keeping this open as a bug then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.