GNU bug report logs - #6303
23.2; Win32 Antialiased fonts

Previous Next

Packages: w32, emacs;

Reported by: Damyan Pepper <damyanp <at> gmail.com>

Date: Sat, 29 May 2010 15:57:01 UTC

Severity: normal

Tags: patch

Found in version 23.2

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #56 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org, Damyan Pepper <damyanp <at> gmail.com>
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Fri, 20 Aug 2010 23:58:21 +0200

> Another thing. This bit:

>            char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL;
>            if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false";
>            if (str == NULL) str = "true";

> would perhaps be clearer as

> 	    char *str;

> 	    if (INTEGERP (val))
> 	      str = XINT (val) ? "true" : "false";
> 	    else if (SYMBOLP (val))
> 	      str = SDATA (SYMBOL_NAME (val));
> 	    else
> 	      str = "true";

Actually, I'd write it:

    char *str = (INTEGERP (val) ? (XINT (val) ? "true" : "false")
                 : SYMBOLP (val) ? SDATA (SYMBOL_NAME (val))
                 : "true")


-- Stefan "look'ma! no assignment!"
This bug report was last modified 14 years and 224 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.