GNU bug report logs - #6303
23.2; Win32 Antialiased fonts

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6303 in the body.
You can then email your comments to 6303 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; Win32 Antialiased fonts
Date: Sat, 29 May 2010 09:37:11 +0100

I'm having trouble getting antialiased fonts to work correctly in
emacs 23.2, to the extent that it appears that it doesn't actually
support antialised fonts.

If I do the following in emacs 23.1:

(set-face-font 'default "DejaVu Sans Mono-9.0:antialias=subpixel")
(describe-font nil)

Then this reports the full name as "DejaVu Sans
Mono-9.0:antialias=subpixel", and the font looks nice and smooth.

However, doing the same thing in emacs 23.2 gives the full name as
"DejaVu Sans Mono-9.0" and the font looks nasty and chunky.

Using bzr bisect I've narrowed this down to revision 98629 - "Handle
system default font and changing font parameters".  This seems to add
some new code for dealing with font changes.  It looks like the
'antialias' argument is now recognised on non-win32 systems and so
this may have inadvertently changed the way it behaves under windows.

In GNU Emacs 23.2.1 (i386-mingw-nt5.2.3790)
 of 2010-05-08 on G41R2F1
Windowing system distributor `Microsoft Corp.', version 5.2.3790
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENG
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> M-x r e p o r t <tab> <ret
urn>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message ecomplete rfc822 mml easymenu mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1
hex-util hashcash mail-utils emacsbug tooltip ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars
tool-bar dnd fontset image fringe lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process multi-tty emacs)

Message #8 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Thu, 3 Jun 2010 12:33:37 +0100

Damyan Pepper <damyanp <at> gmail.com> writes:

> I'm having trouble getting antialiased fonts to work correctly in
> emacs 23.2, to the extent that it appears that it doesn't actually
> support antialised fonts.

The problem here seems to be that the w32 font driver doesn't have a
filter_properties function.

I'm putting together a patch now to give it one - as far as I can tell
this needs to be done to get the :script and :antialias properties to
work.

Message #11 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Thu, 3 Jun 2010 12:56:36 +0100

[Message part 1 (text/plain, inline)]

Attached is a bzr bundle that should fix this issue.

[bugfix_6303.txt (text/plain, attachment)]

Message #14 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 09:24:52 +0100

On Thu, Jun 3, 2010 at 12:56 PM, Damyan Pepper <damyanp <at> gmail.com> wrote:
> Attached is a bzr bundle that should fix this issue.
>

Is there anything I need to do to get this committed, or should I just
wait until someone gets round to it?

Message #17 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 11:03:33 +0200

On Tue, Jun 29, 2010 at 10:24, Damyan Pepper <damyanp <at> gmail.com> wrote:

> Is there anything I need to do to get this committed, or should I just
> wait until someone gets round to it?

Could you provide an example of an antialiased font that works better
with your patch? (Just to see the difference).

Also, your contribution is long enought that it would likely require
for you to sign papers. Have you done so?

Another thing. This bit:

           char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL;
           if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false";
           if (str == NULL) str = "true";

would perhaps be clearer as

	    char *str;

	    if (INTEGERP (val))
	      str = XINT (val) ? "true" : "false";
	    else if (SYMBOLP (val))
	      str = SDATA (SYMBOL_NAME (val));
	    else
	      str = "true";

don't you agree?

    Juanma

Message #20 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 11:05:21 +0200

On Tue, Jun 29, 2010 at 11:03, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> Could you provide an example of an antialiased font that works better
> with your patch? (Just to see the difference).

Excuse the noise, I see that you already did that on the original report.

    Juanma

Message #23 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 11:24:44 +0200

On Thu, Jun 3, 2010 at 13:33, Damyan Pepper <damyanp <at> gmail.com> wrote:

> I'm putting together a patch now to give it one - as far as I can tell
> this needs to be done to get the :script and :antialias properties to
> work.

Yes, the patch works (at least for :antialias, I didn't test :script),
though of course you need to deactivate ClearType to see it.

    Juanma

Message #26 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 10:28:37 +0100

On Tue, Jun 29, 2010 at 10:03 AM, Juanma Barranquero <lekktu <at> gmail.com> wrote:

Thanks for having a look at this.


> Also, your contribution is long enought that it would likely require
> for you to sign papers. Have you done so?

I haven't.


> Another thing. This bit:
>
>           char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL;
>           if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false";
>           if (str == NULL) str = "true";
>
> would perhaps be clearer as
>
>            char *str;
>
>            if (INTEGERP (val))
>              str = XINT (val) ? "true" : "false";
>            else if (SYMBOLP (val))
>              str = SDATA (SYMBOL_NAME (val));
>            else
>              str = "true";
>
> don't you agree?

I do.

I arranged for the code to be very similar to the code in ftfont.c -
it's pretty much a copy with some renamings and a different list of
properties.  The idea was that it should be easy to refactor this so
that the two versions share the same code but pass in different arrays
of property names.  Unfortunately I don't have access to a machine to
test any changes to ftfont.c on and so wasn't confident to make it
blind and without some guidance from someone more experience with the
code base.

I'm happy to try and do the refactor myself - perhaps moving the
generic version of w32font_filter_properties/ftfont_filter_properties
into font.h/font.c?  At that point I'd be happier about doing a pass
through to clear up any logic in there.

Message #29 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 11:38:14 +0200

On Tue, Jun 29, 2010 at 11:28, Damyan Pepper <damyanp <at> gmail.com> wrote:

> I haven't.

Well, then I recommend you do (assuming you're not philosophically or
legally unable to do it), because we need them to accept contributions
larger than about 10 significant lines.

> I arranged for the code to be very similar to the code in ftfont.c -
> it's pretty much a copy with some renamings and a different list of
> properties.

Oh, I see. I didn't look at the ftfont.c code; but if it is like so,
it's a bit obscure IMHO.

> I'm happy to try and do the refactor myself - perhaps moving the
> generic version of w32font_filter_properties/ftfont_filter_properties
> into font.h/font.c?  At that point I'd be happier about doing a pass
> through to clear up any logic in there.

Send the refactored patch, so we don't need to test two different ones.

    Juanma

Message #32 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 11:07:51 +0100

On Tue, Jun 29, 2010 at 10:38 AM, Juanma Barranquero <lekktu <at> gmail.com> wrote:
> Send the refactored patch, so we don't need to test two different ones.

I'll do that.

Thanks for the help,

Damyan.

Message #35 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org, damyanp <at> gmail.com
Subject: Re: bug#6303: Acknowledgement (23.2; Lose32 Antialiased fonts)
Date: Tue, 29 Jun 2010 16:10:22 -0400

Would you please not use the term "win" to refer to that pile of
lossage?

Message #38 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Thu, 1 Jul 2010 17:07:11 +0100

[Message part 1 (text/plain, inline)]

> On Tue, Jun 29, 2010 at 10:38 AM, Juanma Barranquero <lekktu <at> gmail.com> wrote:
>> Send the refactored patch, so we don't need to test two different ones.

Attached is the refactored patch.

I've moved the implementation of ftfont_filter_properties into
font_filter_properties, also applying the cleanup you suggested.
ftfont_filter_properties now calls this new function. Added
w32font_filter_properties.

I'm afraid I've not been able to test this in an environment that uses ftfont.

Are you able to advise me on how to go about getting hold of the papers to sign?

Regards,

Damyan.

[bugfix_6303-v2.txt (text/plain, attachment)]

Message #41 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Fri, 2 Jul 2010 10:59:37 +0200

On Thu, Jul 1, 2010 at 18:07, Damyan Pepper <damyanp <at> gmail.com> wrote:

> Attached is the refactored patch.

Thanks.

> I'm afraid I've not been able to test this in an environment that uses ftfont.

I'll try it, but I don't think there will be any shortage of testers
for the non-Windows parts of the change ;-)

> Are you able to advise me on how to go about getting hold of the papers to sign?

Glenn knows about that more than I do. I'm Cc:ing him.

    Juanma

Message #44 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org, Damyan Pepper <damyanp <at> gmail.com>
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Fri, 02 Jul 2010 13:15:16 -0400

>> Are you able to advise me on how to go about getting hold of the
>> papers to sign?

Sent off-list.

Message #47 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 6303 <at> debbugs.gnu.org, Damyan Pepper <damyanp <at> gmail.com>
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Fri, 2 Jul 2010 19:29:24 +0200

On Fri, Jul 2, 2010 at 19:15, Glenn Morris <rgm <at> gnu.org> wrote:

> Sent off-list.

Thanks.

    Juanma

Message #50 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Damyan Pepper <damyanp <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Thu, 12 Aug 2010 14:59:11 +0100

Just to let you know, my signed papers have been received by the FSF.

Regards,

Damyan.

Message #53 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Thu, 12 Aug 2010 20:33:49 +0200

On Thu, Aug 12, 2010 at 15:59, Damyan Pepper <damyanp <at> gmail.com> wrote:

> Just to let you know, my signed papers have been received by the FSF.

Great. I'll install your change as soon as possible.

    Juanma

Message #56 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org, Damyan Pepper <damyanp <at> gmail.com>
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Fri, 20 Aug 2010 23:58:21 +0200

> Another thing. This bit:

>            char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL;
>            if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false";
>            if (str == NULL) str = "true";

> would perhaps be clearer as

> 	    char *str;

> 	    if (INTEGERP (val))
> 	      str = XINT (val) ? "true" : "false";
> 	    else if (SYMBOLP (val))
> 	      str = SDATA (SYMBOL_NAME (val));
> 	    else
> 	      str = "true";

Actually, I'd write it:

    char *str = (INTEGERP (val) ? (XINT (val) ? "true" : "false")
                 : SYMBOLP (val) ? SDATA (SYMBOL_NAME (val))
                 : "true")


-- Stefan "look'ma! no assignment!"

Message #59 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6303 <at> debbugs.gnu.org, Damyan Pepper <damyanp <at> gmail.com>
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Sat, 21 Aug 2010 00:00:52 +0200

On Fri, Aug 20, 2010 at 23:58, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> Actually, I'd write it:
>
>    char *str = (INTEGERP (val) ? (XINT (val) ? "true" : "false")
>                 : SYMBOLP (val) ? SDATA (SYMBOL_NAME (val))
>                 : "true")
>

I'm all for that kind of thing, but I'm not sure I actually find it
more readable (more "elegant", for some definition of elegant, yes).

    Juanma

Message #64 received at 6303-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303-done <at> debbugs.gnu.org
Subject: Re: bug#6303: W32 Antialiased fonts
Date: Wed, 13 Oct 2010 16:08:07 +0200

On Thu, Aug 12, 2010 at 20:33, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> Great. I'll install your change as soon as possible.

Well, perhaps not "as soon as possible", but it is now committed to
emacs-23, and will be in the trunk in a few days.

Thanks,

    Juanma

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.