GNU bug report logs - #6303
23.2; Win32 Antialiased fonts

Previous Next

Full log

Message #17 received at 6303 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Damyan Pepper <damyanp <at> gmail.com>
Cc: 6303 <at> debbugs.gnu.org
Subject: Re: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 11:03:33 +0200

On Tue, Jun 29, 2010 at 10:24, Damyan Pepper <damyanp <at> gmail.com> wrote:

> Is there anything I need to do to get this committed, or should I just
> wait until someone gets round to it?

Could you provide an example of an antialiased font that works better
with your patch? (Just to see the difference).

Also, your contribution is long enought that it would likely require
for you to sign papers. Have you done so?

Another thing. This bit:

           char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL;
           if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false";
           if (str == NULL) str = "true";

would perhaps be clearer as

	    char *str;

	    if (INTEGERP (val))
	      str = XINT (val) ? "true" : "false";
	    else if (SYMBOLP (val))
	      str = SDATA (SYMBOL_NAME (val));
	    else
	      str = "true";

don't you agree?

    Juanma

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.