GNU bug report logs - #62909
[PATCH] etc: snippets: Fix git-commit-mode configuration for tempel.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Graves <ngraves <at> ngraves.fr>
Subject: bug#62909: closed (Re: [bug#62909] [PATCH] etc: snippets: Fix
 git-commit-mode configuration for tempel.)
Date: Tue, 18 Apr 2023 11:07:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#62909: [PATCH] etc: snippets: Fix git-commit-mode configuration for tempel.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62909 <at> debbugs.gnu.org.

-- 
62909: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62909
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrew Tropin <andrew <at> trop.in>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>,
 62909-done <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: Re: [bug#62909] [PATCH] etc: snippets: Fix git-commit-mode
 configuration for tempel.
Date: Tue, 18 Apr 2023 15:06:03 +0400

[Message part 3 (text/plain, inline)]

On 2023-04-17 19:52, Nicolas Graves via Guix-patches via wrote:

> * etc/snippets/tempel/text-mode: Fix git-commit-mode configuration for tempel.
> ---
>  etc/snippets/tempel/text-mode | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/snippets/tempel/text-mode b/etc/snippets/tempel/text-mode
> index 1cda91cba0..c635b7ee6f 100644
> --- a/etc/snippets/tempel/text-mode
> +++ b/etc/snippets/tempel/text-mode
> @@ -1,6 +1,6 @@
>  -*- mode: lisp-data -*-
>  
> -text-mode :when (and (fboundp 'git-commit-mode) git-commit-mode)
> +text-mode :when (bound-and-true-p git-commit-mode)
>  
>  (add\ "gnu: Add "
>        (p (with-temp-buffer

Hi Nicolas!

Thank you for the patch, applied, reworded commit message, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=38fa64c4b5

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] etc: snippets: Fix git-commit-mode configuration for tempel.
Date: Mon, 17 Apr 2023 19:52:22 +0200

* etc/snippets/tempel/text-mode: Fix git-commit-mode configuration for tempel.
---
 etc/snippets/tempel/text-mode | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/snippets/tempel/text-mode b/etc/snippets/tempel/text-mode
index 1cda91cba0..c635b7ee6f 100644
--- a/etc/snippets/tempel/text-mode
+++ b/etc/snippets/tempel/text-mode
@@ -1,6 +1,6 @@
 -*- mode: lisp-data -*-
 
-text-mode :when (and (fboundp 'git-commit-mode) git-commit-mode)
+text-mode :when (bound-and-true-p git-commit-mode)
 
 (add\ "gnu: Add "
       (p (with-temp-buffer
-- 
2.39.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.