GNU bug report logs - #62909
[PATCH] etc: snippets: Fix git-commit-mode configuration for tempel.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62909 in the body.
You can then email your comments to 62909 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: guix-patches <at> gnu.org
Cc: ngraves <at> ngraves.fr
Subject: [PATCH] etc: snippets: Fix git-commit-mode configuration for tempel.
Date: Mon, 17 Apr 2023 19:52:22 +0200

* etc/snippets/tempel/text-mode: Fix git-commit-mode configuration for tempel.
---
 etc/snippets/tempel/text-mode | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/etc/snippets/tempel/text-mode b/etc/snippets/tempel/text-mode
index 1cda91cba0..c635b7ee6f 100644
--- a/etc/snippets/tempel/text-mode
+++ b/etc/snippets/tempel/text-mode
@@ -1,6 +1,6 @@
 -*- mode: lisp-data -*-
 
-text-mode :when (and (fboundp 'git-commit-mode) git-commit-mode)
+text-mode :when (bound-and-true-p git-commit-mode)
 
 (add\ "gnu: Add "
       (p (with-temp-buffer
-- 
2.39.2

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Nicolas Graves via Guix-patches via <guix-patches <at> gnu.org>,
 62909-done <at> debbugs.gnu.org
Cc: ngraves <at> ngraves.fr
Subject: Re: [bug#62909] [PATCH] etc: snippets: Fix git-commit-mode
 configuration for tempel.
Date: Tue, 18 Apr 2023 15:06:03 +0400

[Message part 1 (text/plain, inline)]

On 2023-04-17 19:52, Nicolas Graves via Guix-patches via wrote:

> * etc/snippets/tempel/text-mode: Fix git-commit-mode configuration for tempel.
> ---
>  etc/snippets/tempel/text-mode | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/etc/snippets/tempel/text-mode b/etc/snippets/tempel/text-mode
> index 1cda91cba0..c635b7ee6f 100644
> --- a/etc/snippets/tempel/text-mode
> +++ b/etc/snippets/tempel/text-mode
> @@ -1,6 +1,6 @@
>  -*- mode: lisp-data -*-
>  
> -text-mode :when (and (fboundp 'git-commit-mode) git-commit-mode)
> +text-mode :when (bound-and-true-p git-commit-mode)
>  
>  (add\ "gnu: Add "
>        (p (with-temp-buffer

Hi Nicolas!

Thank you for the patch, applied, reworded commit message, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=38fa64c4b5

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.