GNU bug report logs - #62769
pcre: correct overpessimistic error checking of pcre2_jit_compile()

Previous Next

Package: grep;

Reported by: Carlo Arenas <carenas <at> gmail.com>

Date: Tue, 11 Apr 2023 06:48:02 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Carlo Arenas <carenas <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 62769 <at> debbugs.gnu.org
Subject: bug#62769: pcre: correct overpessimistic error checking of pcre2_jit_compile()
Date: Tue, 11 Apr 2023 23:08:45 -0700

On Tue, Apr 11, 2023 at 3:11 PM Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>
> On 4/10/23 23:47, Carlo Arenas wrote:
> > The original code was done in a way that would be useful during
> > porting, but that would hinder future work unnecessarily.
>
> Thanks, but wouldn't the attached patch be better?

Yes. but I would probably prefer voiding the return value to make it explicit.

> If I understand you
> correctly, we can simply ignore pcre2_jit_compile failure as the search
> will still succeed (albeit perhaps more slowly).

correct.

Carlo
This bug report was last modified 2 years and 35 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.