GNU bug report logs - #62769
pcre: correct overpessimistic error checking of pcre2_jit_compile()

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62769 in the body.
You can then email your comments to 62769 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Carlo Arenas <carenas <at> gmail.com>
To: bug-grep <at> gnu.org
Subject: pcre: correct overpessimistic error checking of pcre2_jit_compile()
Date: Mon, 10 Apr 2023 23:47:08 -0700

[Message part 1 (text/plain, inline)]

The original code was done in a way that would be useful during
porting, but that would hinder future work unnecessarily.

Carlo

[0001-pcre-correct-overpessimistic-error-checking-of-pcre2.patch (application/octet-stream, attachment)]

Message #8 received at 62769 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Carlo Arenas <carenas <at> gmail.com>
Cc: 62769 <at> debbugs.gnu.org
Subject: Re: bug#62769: pcre: correct overpessimistic error checking of
 pcre2_jit_compile()
Date: Tue, 11 Apr 2023 15:11:57 -0700

[Message part 1 (text/plain, inline)]

On 4/10/23 23:47, Carlo Arenas wrote:
> The original code was done in a way that would be useful during
> porting, but that would hinder future work unnecessarily.

Thanks, but wouldn't the attached patch be better? If I understand you 
correctly, we can simply ignore pcre2_jit_compile failure as the search 
will still succeed (albet perhaps more slowly).

[0001-grep-make-P-survive-JIT-compilation-failure.patch (text/x-patch, attachment)]

Message #11 received at 62769 <at> debbugs.gnu.org (full text, mbox):

From: Carlo Arenas <carenas <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 62769 <at> debbugs.gnu.org
Subject: Re: bug#62769: pcre: correct overpessimistic error checking of
 pcre2_jit_compile()
Date: Tue, 11 Apr 2023 23:08:45 -0700

On Tue, Apr 11, 2023 at 3:11 PM Paul Eggert <eggert <at> cs.ucla.edu> wrote:
>
> On 4/10/23 23:47, Carlo Arenas wrote:
> > The original code was done in a way that would be useful during
> > porting, but that would hinder future work unnecessarily.
>
> Thanks, but wouldn't the attached patch be better?

Yes. but I would probably prefer voiding the return value to make it explicit.

> If I understand you
> correctly, we can simply ignore pcre2_jit_compile failure as the search
> will still succeed (albeit perhaps more slowly).

correct.

Carlo

Message #16 received at 62769-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Carlo Arenas <carenas <at> gmail.com>
Cc: 62769-done <at> debbugs.gnu.org
Subject: Re: bug#62769: pcre: correct overpessimistic error checking of
 pcre2_jit_compile()
Date: Thu, 13 Apr 2023 14:57:29 -0700

On 4/11/23 23:08, Carlo Arenas wrote:
> Yes. but I would probably prefer voiding the return value to make it explicit.

Thanks for checking. Casting expressions to void is not our style so 
I'll omit that (the comment makes things obvious to the reader anyway). 
So I installed the patch without the cast.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.