GNU bug report logs - #6207
23.1; align.el vhdl rules setup

Previous Next

Package: emacs;

Reported by: Kevin Ryde <user42 <at> zip.com.au>

Date: Tue, 18 May 2010 00:56:02 UTC

Severity: minor

Tags: patch

Found in version 23.1

Fixed in version 27.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>, Kevin Ryde <user42 <at> zip.com.au>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 13:58:01 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> How about the attached patch?

I haven't followed the discussion, just noticed some minor issues:

>  (defcustom align-dq-string-modes
>    (append align-lisp-modes align-c++-modes align-perl-modes
> -	  '(python-mode))
> +	  '(python-mode 'vhdl-mode))
                        ^
Stray quote?

> +(make-obsolete-variable 'align-vhdl-rules-list "not used" "27.1")
                                                  ^^^^^^^^^^
This produces the following in *Help*:

  This variable is obsolete since 27.1;
  not used

I think "it is no longer used." or similar, with trailing full stop,
would read better.

>  (defun align-set-vhdl-rules ()
>    "Setup the `align-mode-rules-list' variable for `vhdl-mode'."
> +  (define (obsolete nil "27.1"))
      ^^^^^^
declare?

Thanks,

-- 
Basil
This bug report was last modified 5 years and 290 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.