GNU bug report logs - #6207
23.1; align.el vhdl rules setup

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6207 in the body.
You can then email your comments to 6207 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; align.el vhdl rules setup
Date: Tue, 18 May 2010 10:54:45 +1000

align.el has some setups for vhdl-mode, but the way align.el adds to
vhdl-mode-hook means they only take effect in vhdl-mode buffers made
after align.el has loaded, whereas I hoped they would be always present.

Eg. the foo.vhd below

    emacs -Q foo.vhd
    M-x end-of-buffer
    M-x align

does nothing, but

    emacs -Q
    M-: (require 'align)
    C-x C-f foo.vhd
    M-x end-of-buffer
    M-x align

lines up the "signal" and "variable" expressions.

I see there's a comment in align.el that its vhdl stuff belongs in
vhdl-mode.el.  I suppose that would be the right way to do it.

(vhdl-mode has some of its own alignment, the align.el bits are separate
and don't interfere as far as I can tell.  From the comments I get the
impression align.el came afterwards, or some such.)


In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
 of 2009-09-14 on raven, modified by Debian
configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default-enable-multibyte-characters: t

Message #8 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Reto Zimmermann <reto <at> gnu.org>
Cc: 6207 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>,
	Kevin Ryde <user42 <at> zip.com.au>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Tue, 18 May 2010 23:35:30 -0400

Hi Reto,

What do you think of moving the VHDL settings of align.el to vhdl.el?
It sounds like The Right Thing to me,


        Stefan


> align.el has some setups for vhdl-mode, but the way align.el adds to
> vhdl-mode-hook means they only take effect in vhdl-mode buffers made
> after align.el has loaded, whereas I hoped they would be always present.

> Eg. the foo.vhd below

>     emacs -Q foo.vhd
>     M-x end-of-buffer
>     M-x align

> does nothing, but

>     emacs -Q
>     M-: (require 'align)
>     C-x C-f foo.vhd
>     M-x end-of-buffer
>     M-x align

> lines up the "signal" and "variable" expressions.

> I see there's a comment in align.el that its vhdl stuff belongs in
> vhdl-mode.el.  I suppose that would be the right way to do it.

> (vhdl-mode has some of its own alignment, the align.el bits are separate
> and don't interfere as far as I can tell.  From the comments I get the
> impression align.el came afterwards, or some such.)


> In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
>  of 2009-09-14 on raven, modified by Debian
> configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''

> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: en_AU
>   value of $XMODIFIERS: nil
>   locale-coding-system: iso-latin-1-unix
>   default-enable-multibyte-characters: t

Message #11 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: John Wiegley <jwiegley <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org,
	John Wiegley <johnw <at> gnu.org>, Kevin Ryde <user42 <at> zip.com.au>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Wed, 19 May 2010 05:54:11 -0400

On May 18, 2010, at 11:35 PM, Stefan Monnier wrote:

> What do you think of moving the VHDL settings of align.el to vhdl.el?
> It sounds like The Right Thing to me,

This sounds like the right thing to me too.  These settings were made in align.el long before it was as established as it is.

John

Message #14 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Reto Zimmermann <reto <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: "6207 <at> debbugs.gnu.org" <6207 <at> debbugs.gnu.org>, John Wiegley <johnw <at> gnu.org>,
	Kevin Ryde <user42 <at> zip.com.au>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Tue, 01 Jun 2010 15:06:59 +0200

Hi Stefan,

The settings in align.el are not used at all in vhdl-mode.  vhdl-mode has it's own alignment settings and commands, which have evolved since the settings in align.el were defined.  So the settings in align.el are obsolete and could be removed.

Reto


Stefan Monnier wrote:
> Hi Reto,
> 
> What do you think of moving the VHDL settings of align.el to vhdl.el?
> It sounds like The Right Thing to me,
> 
> 
>         Stefan
> 
> 
>> align.el has some setups for vhdl-mode, but the way align.el adds to
>> vhdl-mode-hook means they only take effect in vhdl-mode buffers made
>> after align.el has loaded, whereas I hoped they would be always present.
> 
>> Eg. the foo.vhd below
> 
>>     emacs -Q foo.vhd
>>     M-x end-of-buffer
>>     M-x align
> 
>> does nothing, but
> 
>>     emacs -Q
>>     M-: (require 'align)
>>     C-x C-f foo.vhd
>>     M-x end-of-buffer
>>     M-x align
> 
>> lines up the "signal" and "variable" expressions.
> 
>> I see there's a comment in align.el that its vhdl stuff belongs in
>> vhdl-mode.el.  I suppose that would be the right way to do it.
> 
>> (vhdl-mode has some of its own alignment, the align.el bits are separate
>> and don't interfere as far as I can tell.  From the comments I get the
>> impression align.el came afterwards, or some such.)
> 
> 
>> In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
>>  of 2009-09-14 on raven, modified by Debian
>> configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g -O2' 'LDFLAGS=-g' 'CPPFLAGS=''
> 
>> Important settings:
>>   value of $LC_ALL: nil
>>   value of $LC_COLLATE: nil
>>   value of $LC_CTYPE: nil
>>   value of $LC_MESSAGES: nil
>>   value of $LC_MONETARY: nil
>>   value of $LC_NUMERIC: nil
>>   value of $LC_TIME: nil
>>   value of $LANG: en_AU
>>   value of $XMODIFIERS: nil
>>   locale-coding-system: iso-latin-1-unix
>>   default-enable-multibyte-characters: t
> 
> 
> 

Message #17 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: Reto Zimmermann <reto <at> gnu.org>
Cc: "6207 <at> debbugs.gnu.org" <6207 <at> debbugs.gnu.org>, John Wiegley <johnw <at> gnu.org>,
	Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Tue, 08 Jun 2010 11:53:50 +1000

Reto Zimmermann <reto <at> gnu.org> writes:
>
> So the settings in align.el are obsolete and could be removed.

The mechanisms in align.el seem a bit more general.
Should vhdl be using it perhaps with updates to the rules list?

Message #20 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Reto Zimmermann <reto <at> gnu.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: "6207 <at> debbugs.gnu.org" <6207 <at> debbugs.gnu.org>, John Wiegley <johnw <at> gnu.org>,
	Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Tue, 08 Jun 2010 15:18:46 +0200

Kevin Ryde wrote:
> Reto Zimmermann <reto <at> gnu.org> writes:
>> So the settings in align.el are obsolete and could be removed.
> 
> The mechanisms in align.el seem a bit more general.
> Should vhdl be using it perhaps with updates to the rules list?

The alignment code in vhdl-mode is customized and fine-tuned for VHDL in a a way that I think cannot be implemented with the more general align.el.

Message #23 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Reto Zimmermann <reto <at> gnu.org>
Cc: "6207 <at> debbugs.gnu.org" <6207 <at> debbugs.gnu.org>, John Wiegley <johnw <at> gnu.org>,
 Kevin Ryde <user42 <at> zip.com.au>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 13:04:38 +0200

[Message part 1 (text/plain, inline)]

Reto Zimmermann <reto <at> gnu.org> writes:

> The settings in align.el are not used at all in vhdl-mode.  vhdl-mode
> has it's own alignment settings and commands, which have evolved since
> the settings in align.el were defined.  So the settings in align.el
> are obsolete and could be removed.

How about the attached patch?

Best regards,
Stefan Kangas

[Message part 2 (text/html, inline)]

[0001-Declare-unused-vhdl-code-in-align.el-obsolete.patch (text/x-patch, attachment)]

Message #30 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org,
 John Wiegley <johnw <at> gnu.org>, Kevin Ryde <user42 <at> zip.com.au>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 13:58:01 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> How about the attached patch?

I haven't followed the discussion, just noticed some minor issues:

>  (defcustom align-dq-string-modes
>    (append align-lisp-modes align-c++-modes align-perl-modes
> -	  '(python-mode))
> +	  '(python-mode 'vhdl-mode))
                        ^
Stray quote?

> +(make-obsolete-variable 'align-vhdl-rules-list "not used" "27.1")
                                                  ^^^^^^^^^^
This produces the following in *Help*:

  This variable is obsolete since 27.1;
  not used

I think "it is no longer used." or similar, with trailing full stop,
would read better.

>  (defun align-set-vhdl-rules ()
>    "Setup the `align-mode-rules-list' variable for `vhdl-mode'."
> +  (define (obsolete nil "27.1"))
      ^^^^^^
declare?

Thanks,

-- 
Basil

Message #33 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org,
 John Wiegley <johnw <at> gnu.org>, Kevin Ryde <user42 <at> zip.com.au>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 16:15:17 +0200

[Message part 1 (text/plain, inline)]

Basil L. Contovounesios <contovob <at> tcd.ie> writes:
>
> Stefan Kangas <stefan <at> marxist.se> writes:
>
> > How about the attached patch?
>
> I haven't followed the discussion, just noticed some minor issues:

Ugh.  Thanks for spotting these issues.  I'm a bit sick and tired
today, so maybe I should just stay away from coding for the day...

I've attached an updated patch.

Best regards,
Stefan Kangas

[0001-Declare-unused-vhdl-code-in-align.el-obsolete.patch (text/x-patch, attachment)]

Message #36 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org,
 John Wiegley <johnw <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Thu, 26 Sep 2019 18:03:41 +0100

Stefan Kangas <stefan <at> marxist.se> writes:

> Basil L. Contovounesios <contovob <at> tcd.ie> writes:
>>
>> Stefan Kangas <stefan <at> marxist.se> writes:
>>
>> > How about the attached patch?
>>
>> I haven't followed the discussion, just noticed some minor issues:
>
> Ugh.  Thanks for spotting these issues.  I'm a bit sick and tired
> today, so maybe I should just stay away from coding for the day...

Hope you feel better soon!

> I've attached an updated patch.

Thanks, just one remaining nit:

> +(make-obsolete-variable 'align-vhdl-rules-list "no longer used" "27.1")
                                                                ^^
CURRENT-NAME should end with a full stop; see docstring of make-obsolete.

-- 
Basil

Message #39 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org,
 John Wiegley <johnw <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Sat, 28 Sep 2019 13:07:03 +0200

[Message part 1 (text/plain, inline)]

Basil L. Contovounesios <contovob <at> tcd.ie> writes:

> > Ugh.  Thanks for spotting these issues.  I'm a bit sick and tired
> > today, so maybe I should just stay away from coding for the day...
>
> Hope you feel better soon!

Thanks - I feel much better today. :-)

> > I've attached an updated patch.
>
> Thanks, just one remaining nit:
>
> > +(make-obsolete-variable 'align-vhdl-rules-list "no longer used" "27.1")
>                                                                 ^^
> CURRENT-NAME should end with a full stop; see docstring of make-obsolete.

Fixed in the attached patch.  If there are no further comments, I
intend to commit this in a couple of days.

Best regards,
Stefan Kangas

[0001-Declare-unused-vhdl-code-in-align.el-obsolete.patch (text/x-patch, attachment)]

Message #42 received at 6207 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: Reto Zimmermann <reto <at> gnu.org>, 6207 <at> debbugs.gnu.org,
 John Wiegley <johnw <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#6207: 23.1; align.el vhdl rules setup
Date: Fri, 4 Oct 2019 17:14:25 +0200

close 6207 27.1
quit

Stefan Kangas <stefan <at> marxist.se> writes:

> If there are no further comments, I
> intend to commit this in a couple of days.

No further comments in 6 days; pushed as commit dd3592564a.  Closing.

Best regards,
Stefan Kangas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.