GNU bug report logs - #61941
[PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: conses <contact <at> conses.eu>
Cc: 61941 <at> debbugs.gnu.org
Subject: [bug#61941] [PATCH 1/2] gnu: emacs-helpful: Update to 0.20.1c98f6f.
Date: Wed, 08 Mar 2023 15:57:51 +0100

Hello,

conses <contact <at> conses.eu> writes:

> * gnu/packages/emacs-xyz.scm (emacs-helpful): Update to 0.20.1c98f6f.
> [source]: Remove fix-docstring-test.patch.
> [propagated-inputs]: Remove emacs-shut-up.

Thank you. Some comments follow.

> +  (let ((commit "1c98f6f06a85def5d34c735f8cd407f20cebddf9")
> +        (revision "0"))

Is there a particular reason to use an unreleased version?

> +    (package
> +      (name "emacs-helpful")
> +      (version (git-version "0.20" revision commit))

Base version is actually still 0.19. Upstream bumped Version keyword,
but the README mentions there is no official 0.20 yet. I suggest to
stick to 0.19.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/Wilfred/helpful")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "18b5hjfji51zxjrxhkklxx3j9svk295awmxv8n95mp8ilas2kd3l"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs
> +       (list emacs-elisp-refs emacs-dash emacs-s emacs-f))

While you're at it, could you re-order inputs alphabetically?

You can also merge both patches.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.