GNU bug report logs - #61869
gnu: services: Add more dnsmasq options.

Previous Next

Full log

Message #11 received at 61869 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 61869 <at> debbugs.gnu.org
Subject: Re: gnu: services: Add more dnsmasq options.
Date: Tue, 15 Aug 2023 17:20:03 +0200

[Message part 1 (text/plain, inline)]

Hi Gabriel,

I've rebased this patch onto current master (attached).  I've also made 
some changes in a third patch that I'd like *you* to review, and ideally 
test.

Some remarks:
- For the commit message, I prefer ‘services: foo:’ to ‘gnu: services:’.
- Use the previous Texinfo @node{} title in the commit message.
- I added bind-interfaces? only because it occurs in my documentation 
for another new option.
- I don't use the dnsmasq service so I'm not 100% confident about some 
of my changes.  Please let me know if, for example, something doesn't 
make sense as a list.

Thanks!

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

[0001-services-dnsmasq-Add-more-service-options.patch (text/x-diff, attachment)]

[0002-services-dnsmasq-Fix-some-indentation.patch (text/x-diff, attachment)]

[0003-f-dnsmasq.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.