GNU bug report logs - #61869
gnu: services: Add more dnsmasq options.

Previous Next

To reply to this bug, email your comments to 61869 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: gnu: services: Add more dnsmasq options.
Date: Tue, 28 Feb 2023 13:36:16 +0000

[Message part 1 (text/plain, inline)]

Hi y'all

I've created a patch which adds more options to the dnsmasq service.  Thanks in advance for merging,

g

[Message part 2 (text/html, inline)]

[0001-gnu-services-Add-more-dnsmasq-options.patch (text/x-patch, attachment)]

Message #8 received at 61869 <at> debbugs.gnu.org (full text, mbox):

From: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>
To: "61869 <at> debbugs.gnu.org" <61869 <at> debbugs.gnu.org>
Subject: Updated patch
Date: Wed, 8 Mar 2023 14:56:20 +0000

[Message part 1 (text/plain, inline)]

Hi

There were two small changes i wanted to address before merging:
 - the standard /24 block for documenting is 192.0.2.0/24
 - i had the default option for --no-poll (poll?) wrong in the documentation.

[Message part 2 (text/html, inline)]

[0001-gnu-services-Add-more-dnsmasq-options.patch (text/x-patch, attachment)]

Message #11 received at 61869 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 61869 <at> debbugs.gnu.org
Subject: Re: gnu: services: Add more dnsmasq options.
Date: Tue, 15 Aug 2023 17:20:03 +0200

[Message part 1 (text/plain, inline)]

Hi Gabriel,

I've rebased this patch onto current master (attached).  I've also made 
some changes in a third patch that I'd like *you* to review, and ideally 
test.

Some remarks:
- For the commit message, I prefer ‘services: foo:’ to ‘gnu: services:’.
- Use the previous Texinfo @node{} title in the commit message.
- I added bind-interfaces? only because it occurs in my documentation 
for another new option.
- I don't use the dnsmasq service so I'm not 100% confident about some 
of my changes.  Please let me know if, for example, something doesn't 
make sense as a list.

Thanks!

T G-R

Sent from a Web browser.  Excuse or enjoy my brevity.

[0001-services-dnsmasq-Add-more-service-options.patch (text/x-diff, attachment)]

[0002-services-dnsmasq-Fix-some-indentation.patch (text/x-diff, attachment)]

[0003-f-dnsmasq.patch (text/x-diff, attachment)]

Message #14 received at 61869 <at> debbugs.gnu.org (full text, mbox):

From: "Wicki Gabriel (wicg)" <wicg <at> zhaw.ch>
To: "61869 <at> debbugs.gnu.org" <61869 <at> debbugs.gnu.org>
Cc: "me <at> tobias.gr" <me <at> tobias.gr>
Subject: Review of the third patch
Date: Mon, 21 Aug 2023 15:12:04 +0000

[Message part 1 (text/plain, inline)]

Thank you very much for your review and the third patch!

I have 3 small additions to your work (see your adapted patch in the attachments):

  *   I added a commit message (although I guess you'll edit that again anyways)
  *   I extended your explanations on the `interface' option (when bind-dynamic​?` or​ bind-interfaces?​ is set...)
  *   I filled in your TODO

Please let me know (don't forget to cc me in your reply) if I can do anything else to merge this patch-set.

Thanks again, for your time, patience and expertise

gabriel

[Message part 2 (text/html, inline)]

[0003-services-dnsmasq-Fix-inconsistencies.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.