GNU bug report logs - #61734
30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails

Previous Next

Package: emacs;

Reported by: Manuel Giraud <manuel <at> ledu-giraud.fr>

Date: Thu, 23 Feb 2023 16:03:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: 61734 <at> debbugs.gnu.org
Subject: bug#61734: 30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails
Date: Thu, 23 Feb 2023 21:17:55 +0100
[Message part 1 (text/plain, inline)]
Manuel Giraud <manuel <at> ledu-giraud.fr> writes:

> Hi,
>
> Here is a patch to avoid "wrong type error" upon comparision to zero of
> image-dired--number-of-thumbnails.  How to reproduce:
>
>     - Do not have an existing *image-dired* buffer
>     - Hit 'C-t a' (image-dired-display-thumbs-append) on an image file
>       from Dired

Maybe this new version can go in too.  It updates the thumbnails counter
when removing a thumbnail.  What is not updated though is the number of
the image which is assign with a text-property at insertion...  So it is
not complete but an improvement nevertheless.
[0001-Defaults-to-zero-for-image-dired-number-of-thumbnail.patch (text/x-patch, attachment)]
[Message part 3 (text/plain, inline)]
-- 
Manuel Giraud

This bug report was last modified 2 years and 87 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.