GNU bug report logs - #61734
30.0.50; [PATCH] Defaults to zero for image-dired--number-of-thumbnails

Previous Next

Full log

Message #20 received at 61734 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61734 <at> debbugs.gnu.org
Subject: Re: bug#61734: 30.0.50; [PATCH] Defaults to zero for
 image-dired--number-of-thumbnails
Date: Mon, 27 Feb 2023 17:20:10 +0100

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

[...]

> I only ever keep the last version, and it's certainly not for
> emacs-29.

Ok, sorry.  So here is the first version.

[0001-Defaults-to-zero-for-image-dired-number-of-thumbnail.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

> What do you want to install on emacs-29, and what problem(s) is that
> supposed to fix?

This fixes a "wrong type error" when comparing
image-dired--number-of-thumbnails to zero.  Here is a recipe to make it
happen:

    - Do not have an existing *image-dired* buffer
    - Hit 'C-t a' (image-dired-display-thumbs-append) on an image file
      from Dired

And you're right that the rest of the patch should not go into emacs-29.
-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.