GNU bug report logs - #61549
30.0.50; [PATCH] New keyboard macro counter functions

Previous Next

Full log

Message #23 received at 61549 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Alex Bochannek <alex <at> bochannek.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, larsi <at> gnus.org, 61549 <at> debbugs.gnu.org,
 monnier <at> iro.umontreal.ca
Subject: Re: bug#61549: 30.0.50; [PATCH] New keyboard macro counter functions
Date: Sun, 12 Mar 2023 01:19:01 +0100

Alex Bochannek <alex <at> bochannek.com> writes:

> diff --git a/doc/emacs/kmacro.texi b/doc/emacs/kmacro.texi

Two small notes from me in addition to Eli's review:

> +(defun kmacro-reg-add-counter-equal (&optional arg)
> +  "Increment `kmacro-counter' by ARG if the counter is equal to a
> +register's value.
> +ARG is the numeric prefix argument that defaults to one."
> +  (interactive "p")
> +  (let
> +      ((register (register-read-with-preview "Compare counter to register: ")))
> +    (kmacro-reg-add-counter '= register arg)))
                               ^^
I think we should function quote here; similar in most of the other
functions.

> +(defun kmacro-quit-counter-equal (&optional arg)
> +  "Quit the keyboard macro if `kmacro-counter' is equal to ARG.
> +ARG is the numeric prefix argument that defaults to zero."
> +  (interactive "P")
> +  (kmacro-quit-counter '= arg))

Is there a reason why the code starts to use the raw prefix here
(capital "P")?


TIA,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.