GNU bug report logs - #61550
30.0.50; c-ts-mode comment-style

Previous Next

Package: emacs;

Reported by: Felix <felix.dick <at> web.de>

Date: Thu, 16 Feb 2023 12:13:02 UTC

Severity: normal

Found in version 30.0.50

Fixed in version 29.1

Done: Theodor Thornhill <theo <at> thornhill.no>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61550 in the body.
You can then email your comments to 61550 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#61550; Package emacs. (Thu, 16 Feb 2023 12:13:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Felix <felix.dick <at> web.de>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 16 Feb 2023 12:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Felix <felix.dick <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; c-ts-mode comment-style
Date: Thu, 16 Feb 2023 13:08:46 +0100

c-ts-mode needs it's own version of the command 'c-toggle-comment-style'.
Invoking the original 'c-toggle-comment-style' in c-ts-mode breaks the
comment functions.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61550; Package emacs. (Fri, 17 Feb 2023 22:52:02 GMT) Full text and rfc822 format available.

Message #8 received at 61550 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Felix <felix.dick <at> web.de>
Cc: 61550 <at> debbugs.gnu.org
Subject: Re: bug#61550: 30.0.50; c-ts-mode comment-style
Date: Fri, 17 Feb 2023 23:51:10 +0100

[Message part 1 (text/plain, inline)]
Hi Felix!

> c-ts-mode needs it's own version of the command 'c-toggle-comment-style'.
> Invoking the original 'c-toggle-comment-style' in c-ts-mode breaks the
> comment functions.

Can you test this for me?  It seems to behave similarly to
c-toggle-comment-style, right?  Are you satisfied with this?

And what do you think, Eli, too big for emacs-29?

Theo


[0001-Add-comment-style-toggle-for-c-ts-mode.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61550; Package emacs. (Fri, 17 Feb 2023 23:55:02 GMT) Full text and rfc822 format available.

Message #11 received at 61550 <at> debbugs.gnu.org (full text, mbox):

From: Felix <felix.dick <at> web.de>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 61550 <at> debbugs.gnu.org
Subject: Re: bug#61550: 30.0.50; c-ts-mode comment-style
Date: Sat, 18 Feb 2023 00:46:10 +0100

Hi Theodor,
it works!
Thanks a lot!

Theodor Thornhill <theo <at> thornhill.no> writes:

> Hi Felix!
>
>> c-ts-mode needs it's own version of the command 'c-toggle-comment-style'.
>> Invoking the original 'c-toggle-comment-style' in c-ts-mode breaks the
>> comment functions.
>
> Can you test this for me?  It seems to behave similarly to
> c-toggle-comment-style, right?  Are you satisfied with this?
>
> And what do you think, Eli, too big for emacs-29?
>
> Theo
>
> [2. text/x-patch; 0001-Add-comment-style-toggle-for-c-ts-mode.patch]...
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61550; Package emacs. (Sat, 18 Feb 2023 07:00:02 GMT) Full text and rfc822 format available.

Message #14 received at 61550 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 61550 <at> debbugs.gnu.org, felix.dick <at> web.de
Subject: Re: bug#61550: 30.0.50; c-ts-mode comment-style
Date: Sat, 18 Feb 2023 08:59:35 +0200

> Cc: 61550 <at> debbugs.gnu.org
> Date: Fri, 17 Feb 2023 23:51:10 +0100
> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> > c-ts-mode needs it's own version of the command 'c-toggle-comment-style'.
> > Invoking the original 'c-toggle-comment-style' in c-ts-mode breaks the
> > comment functions.
> 
> Can you test this for me?  It seems to behave similarly to
> c-toggle-comment-style, right?  Are you satisfied with this?
> 
> And what do you think, Eli, too big for emacs-29?

No, not too big.

Thanks.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#61550; Package emacs. (Sat, 18 Feb 2023 07:25:02 GMT) Full text and rfc822 format available.

Message #17 received at 61550 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61550 <at> debbugs.gnu.org, felix.dick <at> web.de
Subject: Re: bug#61550: 30.0.50; c-ts-mode comment-style
Date: Sat, 18 Feb 2023 08:24:07 +0100


On 18 February 2023 07:59:35 CET, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> Cc: 61550 <at> debbugs.gnu.org
>> Date: Fri, 17 Feb 2023 23:51:10 +0100
>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> > c-ts-mode needs it's own version of the command 'c-toggle-comment-style'.
>> > Invoking the original 'c-toggle-comment-style' in c-ts-mode breaks the
>> > comment functions.
>> 
>> Can you test this for me?  It seems to behave similarly to
>> c-toggle-comment-style, right?  Are you satisfied with this?
>> 
>> And what do you think, Eli, too big for emacs-29?
>
>No, not too big.
>
>Thanks.

Great! Installing later today.

Theo
bug marked as fixed in version 29.1, send any further explanations to 61550 <at> debbugs.gnu.org and Felix <felix.dick <at> web.de> Request was from Theodor Thornhill <theo <at> thornhill.no> to control <at> debbugs.gnu.org. (Mon, 20 Feb 2023 14:11:01 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 21 Mar 2023 11:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 89 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.