GNU bug report logs - #61501
30.0.50; [PATCH] Support unloading Eshell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61501 in the body.
You can then email your comments to 61501 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Support unloading Eshell
Date: Mon, 13 Feb 2023 19:52:13 -0800

[Message part 1 (text/plain, inline)]

Currently, it's not possible to call "(unload-feature 'eshell)" after 
using Eshell. You'll just get an error that some of Eshell's extension 
modules depend on eshell.elc. This is a relatively minor issue, but I'm 
hoping to make some improvements to how extension modules get loaded, so 
this is a prelude to that.

In addition to making it *possible* to unload Eshell, I also fixed an 
issue where the unload hooks weren't named correctly. They were of the 
form 'eshell-hist-unload-hook', but the file's name is em-hist.el. I 
moved these to 'em-hist-unload-function' and similar ('-function' 
because the '-hook' version is obsolete, as I understand it).

[0001-Don-t-require-eshell-in-other-Eshell-files.patch (text/plain, attachment)]

[0002-Allow-unloading-Eshell.patch (text/plain, attachment)]

Message #8 received at 61501 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 61501 <at> debbugs.gnu.org
Subject: Re: bug#61501: 30.0.50; [PATCH] Support unloading Eshell
Date: Tue, 14 Feb 2023 16:34:03 +0200

> Date: Mon, 13 Feb 2023 19:52:13 -0800
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> Currently, it's not possible to call "(unload-feature 'eshell)" after 
> using Eshell. You'll just get an error that some of Eshell's extension 
> modules depend on eshell.elc. This is a relatively minor issue, but I'm 
> hoping to make some improvements to how extension modules get loaded, so 
> this is a prelude to that.
> 
> In addition to making it *possible* to unload Eshell, I also fixed an 
> issue where the unload hooks weren't named correctly. They were of the 
> form 'eshell-hist-unload-hook', but the file's name is em-hist.el. I 
> moved these to 'em-hist-unload-function' and similar ('-function' 
> because the '-hook' version is obsolete, as I understand it).

Thanks, good to hear.  Please add a NEWS entry to call out this
change.

Message #11 received at 61501 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61501 <at> debbugs.gnu.org
Subject: Re: bug#61501: 30.0.50; [PATCH] Support unloading Eshell
Date: Tue, 14 Feb 2023 16:56:54 -0800

[Message part 1 (text/plain, inline)]

On 2/14/2023 6:34 AM, Eli Zaretskii wrote:
> Thanks, good to hear.  Please add a NEWS entry to call out this
> change.

Thanks. How does this look?

[0002-Allow-unloading-Eshell.patch (text/plain, attachment)]

Message #14 received at 61501 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 61501 <at> debbugs.gnu.org
Subject: Re: bug#61501: 30.0.50; [PATCH] Support unloading Eshell
Date: Wed, 15 Feb 2023 14:59:10 +0200

> Date: Tue, 14 Feb 2023 16:56:54 -0800
> Cc: 61501 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> On 2/14/2023 6:34 AM, Eli Zaretskii wrote:
> > Thanks, good to hear.  Please add a NEWS entry to call out this
> > change.
> 
> Thanks. How does this look?

It's okay, but I actually thought about telling that unloading Eshell
now works...

Message #17 received at 61501 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61501 <at> debbugs.gnu.org
Subject: Re: bug#61501: 30.0.50; [PATCH] Support unloading Eshell
Date: Wed, 15 Feb 2023 09:31:57 -0800

[Message part 1 (text/plain, inline)]

On 2/15/2023 4:59 AM, Eli Zaretskii wrote:
>> Date: Tue, 14 Feb 2023 16:56:54 -0800
>> Cc: 61501 <at> debbugs.gnu.org
>> From: Jim Porter <jporterbugs <at> gmail.com>
>>
>> On 2/14/2023 6:34 AM, Eli Zaretskii wrote:
>>> Thanks, good to hear.  Please add a NEWS entry to call out this
>>> change.
>>
>> Thanks. How does this look?
> 
> It's okay, but I actually thought about telling that unloading Eshell
> now works...

Oh, I see. How about this?

I could also try to merge the two news entries. However, since the 
previous one that I added about hook names describes an incompatible 
change, my gut feeling is to keep them separate, or just remove the 
previous entry (I'm not sure anyone uses the old names since they didn't 
work in the first place).

[0002-Allow-unloading-Eshell.patch (text/plain, attachment)]

Message #20 received at 61501 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 61501 <at> debbugs.gnu.org
Subject: Re: bug#61501: 30.0.50; [PATCH] Support unloading Eshell
Date: Wed, 15 Feb 2023 20:06:03 +0200

> Date: Wed, 15 Feb 2023 09:31:57 -0800
> Cc: 61501 <at> debbugs.gnu.org
> From: Jim Porter <jporterbugs <at> gmail.com>
> 
> On 2/15/2023 4:59 AM, Eli Zaretskii wrote:
> >> Date: Tue, 14 Feb 2023 16:56:54 -0800
> >> Cc: 61501 <at> debbugs.gnu.org
> >> From: Jim Porter <jporterbugs <at> gmail.com>
> >>
> >> On 2/14/2023 6:34 AM, Eli Zaretskii wrote:
> >>> Thanks, good to hear.  Please add a NEWS entry to call out this
> >>> change.
> >>
> >> Thanks. How does this look?
> > 
> > It's okay, but I actually thought about telling that unloading Eshell
> > now works...
> 
> Oh, I see. How about this?

Perfect, thanks.

> I could also try to merge the two news entries.

I see no need: they are different aspects of the same changeset.

Message #25 received at 61501-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61501-done <at> debbugs.gnu.org
Subject: Re: bug#61501: 30.0.50; [PATCH] Support unloading Eshell
Date: Wed, 15 Feb 2023 17:34:14 -0800

On 2/15/2023 10:06 AM, Eli Zaretskii wrote:
> Perfect, thanks.

Thanks. Merged to master as 8051be9ac2. Closing this bug now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.