GNU bug report logs - #61500
Default cache directory of cat-avatar-generator-service

Previous Next

To reply to this bug, email your comments to 61500 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: bug-guix <at> gnu.org
Subject: Default cache directory of cat-avatar-generator-service
Date: Tue, 14 Feb 2023 06:10:45 +0300

Hello!

The cache directory must:

1. End with a slash (due to implementation of the php script).
2. Exist or be created manually.
3. Be writeable by php-fpm.

The current default value doesn't meet these requirements and leads to
broken caching and errors in php-fpm log.

The simplest solution is to change it to /tmp/, but for obvious
reasons it is not suitable for production use.

However, since this service is described as demonstration, I would
prefer unsafe default over broken (for now).

Also the requirements above should probably be mentioned in the
documentation of the service.

Message #8 received at 61500 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <evgeny <at> pisemsky.com>
To: 61500 <at> debbugs.gnu.org
Subject: [PATCH] services: cat-http-server: Fix cat-avatar-generator-service.
Date: Thu, 30 Nov 2023 19:38:50 +0300

[Message part 1 (text/plain, inline)]

Here is the simplest patch that changes cache directory to /tmp/ and
makes this service work with the recently added monsterid package.

[0001-services-cat-http-server-Fix-cat-avatar-generator-se.patch (text/x-patch, attachment)]

Message #11 received at 61500 <at> debbugs.gnu.org (full text, mbox):

From: Evgeny Pisemsky <mail <at> pisemsky.site>
To: 61500 <at> debbugs.gnu.org
Subject: Re: Default cache directory of cat-avatar-generator-service
Date: Sat, 14 Dec 2024 21:28:47 +0300

> However, since this service is described as demonstration, I would prefer unsafe default over broken (for now).

I realized that this may look like an attempt to introduce vulnerabity, while in fact I was just silly. Shame on me.

The right thing to do here is to write a normal service instead of simple and create cache directory using activation service.

Or at least to update documentation of the existing service.

If someone at guix reads and wants this, please let me know.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.