GNU bug report logs - #60334
[PATCH] whitespace: Use `define-globalized-minor-mode' for global mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60334: closed ([PATCH] whitespace: Use `define-globalized-minor-mode'
 for global mode)
Date: Sat, 31 Dec 2022 08:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 31 Dec 2022 10:49:55 +0200
with message-id <83tu1c3qks.fsf <at> gnu.org>
and subject line Re: bug#60334: [PATCH] whitespace: Use `define-globalized-minor-mode' for global mode
has caused the debbugs.gnu.org bug report #60334,
regarding [PATCH] whitespace: Use `define-globalized-minor-mode' for global mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60334: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60334
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] whitespace: Use `define-globalized-minor-mode' for global mode
Date: Mon, 26 Dec 2022 01:32:20 -0500

[Message part 3 (text/plain, inline)]

Attached patch:

    whitespace: Use `define-globalized-minor-mode' for global mode

    * lisp/whitespace.el (global-whitespace-mode): Fix interoperability
    between `whitespace-mode' and `global-whitespace-mode' by using
    `define-globalized-minor-mode'.
    * test/lisp/whitespace-tests.el (whitespace-tests--global): Add a
    regression test.

It would be nice to install this on emacs-29, but I'm OK with this going 
on master.

[0001-whitespace-Use-define-globalized-minor-mode-for-glob.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 60334-done <at> debbugs.gnu.org
Subject: Re: bug#60334: [PATCH] whitespace: Use `define-globalized-minor-mode'
 for global mode
Date: Sat, 31 Dec 2022 10:49:55 +0200

> Date: Sat, 31 Dec 2022 03:29:43 -0500
> Cc: 60334 <at> debbugs.gnu.org
> From: Richard Hansen <rhansen <at> rhansen.org>
> 
> On 12/31/22 03:20, Eli Zaretskii wrote:
> > I tried to install this on master (it's too late for such changes on
> > the emacs-29 branch), but the patch failed to apply.  Could you please
> > rebase this on master and resubmit?
> 
> See attached.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.