GNU bug report logs - #60334
[PATCH] whitespace: Use `define-globalized-minor-mode' for global mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60334 in the body.
You can then email your comments to 60334 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] whitespace: Use `define-globalized-minor-mode' for global mode
Date: Mon, 26 Dec 2022 01:32:20 -0500

[Message part 1 (text/plain, inline)]

Attached patch:

    whitespace: Use `define-globalized-minor-mode' for global mode

    * lisp/whitespace.el (global-whitespace-mode): Fix interoperability
    between `whitespace-mode' and `global-whitespace-mode' by using
    `define-globalized-minor-mode'.
    * test/lisp/whitespace-tests.el (whitespace-tests--global): Add a
    regression test.

It would be nice to install this on emacs-29, but I'm OK with this going 
on master.

[0001-whitespace-Use-define-globalized-minor-mode-for-glob.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #8 received at 60334 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 60334 <at> debbugs.gnu.org
Subject: Re: bug#60334: [PATCH] whitespace: Use `define-globalized-minor-mode'
 for global mode
Date: Sat, 31 Dec 2022 10:20:34 +0200

> Date: Mon, 26 Dec 2022 01:32:20 -0500
> From: Richard Hansen <rhansen <at> rhansen.org>
> 
> Attached patch:
> 
>      whitespace: Use `define-globalized-minor-mode' for global mode
> 
>      * lisp/whitespace.el (global-whitespace-mode): Fix interoperability
>      between `whitespace-mode' and `global-whitespace-mode' by using
>      `define-globalized-minor-mode'.
>      * test/lisp/whitespace-tests.el (whitespace-tests--global): Add a
>      regression test.
> 
> It would be nice to install this on emacs-29, but I'm OK with this going 
> on master.

I tried to install this on master (it's too late for such changes on
the emacs-29 branch), but the patch failed to apply.  Could you please
rebase this on master and resubmit?

Thanks.

Message #11 received at 60334 <at> debbugs.gnu.org (full text, mbox):

From: Richard Hansen <rhansen <at> rhansen.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60334 <at> debbugs.gnu.org
Subject: Re: bug#60334: [PATCH] whitespace: Use `define-globalized-minor-mode'
 for global mode
Date: Sat, 31 Dec 2022 03:29:43 -0500

[Message part 1 (text/plain, inline)]

On 12/31/22 03:20, Eli Zaretskii wrote:
> I tried to install this on master (it's too late for such changes on
> the emacs-29 branch), but the patch failed to apply.  Could you please
> rebase this on master and resubmit?

See attached.

Thanks!

[v2-0001-whitespace-Use-define-globalized-minor-mode-for-g.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #16 received at 60334-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 60334-done <at> debbugs.gnu.org
Subject: Re: bug#60334: [PATCH] whitespace: Use `define-globalized-minor-mode'
 for global mode
Date: Sat, 31 Dec 2022 10:49:55 +0200

> Date: Sat, 31 Dec 2022 03:29:43 -0500
> Cc: 60334 <at> debbugs.gnu.org
> From: Richard Hansen <rhansen <at> rhansen.org>
> 
> On 12/31/22 03:20, Eli Zaretskii wrote:
> > I tried to install this on master (it's too late for such changes on
> > the emacs-29 branch), but the patch failed to apply.  Could you please
> > rebase this on master and resubmit?
> 
> See attached.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.