GNU bug report logs - #60212
[PATCH] gnu: Add emacs-fzf.

Previous Next

Full log

View this message in rfc822 format

From: "jgart" <jgart <at> dismail.de>
To: mail <at> nicolasgoaziou.fr, 60212 <at> debbugs.gnu.org
Cc: 60212-done <at> debbugs.gnu.org
Subject: [bug#60212] [PATCH] gnu: Add emacs-fzf.
Date: Wed, 21 Dec 2022 00:54:11 +0000

I keep forgetting re @command

I'll stop doing that. It has become a habit.

Thanks for the review!

It's much appreciated,

jgart

https://whereis.みんな/

December 20, 2022 4:26 AM, "Nicolas Goaziou" <mail <at> nicolasgoaziou.fr> wrote:

> Hello,
> 
> jgart via Guix-patches via <guix-patches <at> gnu.org> writes:
> 
>> * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable.
> 
> Thank you.
> 
>> + #~(modify-phases %standard-phases
>> + (add-after 'unpack 'patch-fzf-executable
>> + (lambda* (#:key inputs #:allow-other-keys)
>> + (make-file-writable "fzf.el")
> 
> Nitpick: The expression above is usually not necessary, even though some
> package definitions use it.
> 
>> + (emacs-substitute-variables "fzf.el"
>> + ("fzf/executable" (search-input-file inputs "/bin/fzf"))))))))
>> + (inputs (list fzf))
>> + (home-page "https://github.com/bling/fzf.el")
>> + (synopsis "Front-end for fzf")
> 
> I expounded it a bit.
> 
>> + (description "An @command{emacs} front-end for @command{fzf}.")
> 
> Please write full sentences in descriptions, even if upstream does not.
> 
> Also, "@command{emacs}" conveys no more information than "Emacs". So
> does "@command{fzf}" vs "Fzf". The simpler the better, IMO.
> 
> Applied!
> 
> Regards,
> --
> Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.