GNU bug report logs - #60212
[PATCH] gnu: Add emacs-fzf.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60212: closed ([PATCH] gnu: Add emacs-fzf.)
Date: Tue, 20 Dec 2022 10:27:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 20 Dec 2022 11:25:58 +0100
with message-id <87ili6cqx5.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#60212] [PATCH] gnu: Add emacs-fzf.
has caused the debbugs.gnu.org bug report #60212,
regarding [PATCH] gnu: Add emacs-fzf.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60212: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60212
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: Add emacs-fzf.
Date: Mon, 19 Dec 2022 21:29:16 -0600

* gnu/packages/emacs-xyz.scm (emacs-fzf): New variable.
---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f97775ce95..6a03d40aca 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -1283,6 +1283,38 @@ (define-public emacs-mct
     (license (list license:gpl3+
                    license:fdl1.3+)))) ; GFDLv1.3+ for the manual
 
+(define-public emacs-fzf
+  (let ((commit "21912ebc7e1084aa88c9d8b7715e782a3978ed23")
+        (revision "0"))
+    (package
+      (name "emacs-fzf")
+      (version (git-version "0.0.2" revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/bling/fzf.el")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "0gdqjh8996hb06bnnyhi94k69mjfrzyfgq00a9s4wwagv28sqmkj"))))
+      (build-system emacs-build-system)
+      (arguments
+        (list
+         #:tests? #f ; There are no tests.
+         #:phases
+         #~(modify-phases %standard-phases
+             (add-after 'unpack 'patch-fzf-executable
+               (lambda* (#:key inputs #:allow-other-keys)
+                 (make-file-writable "fzf.el")
+                 (emacs-substitute-variables "fzf.el"
+                   ("fzf/executable" (search-input-file inputs "/bin/fzf"))))))))
+      (inputs (list fzf))
+      (home-page "https://github.com/bling/fzf.el")
+      (synopsis "Front-end for fzf")
+      (description "An @command{emacs} front-end for @command{fzf}.")
+      (license license:gpl3+))))
+
 (define-public emacs-minions
   (package
     (name "emacs-minions")
-- 
2.38.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: 60212-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>
Subject: Re: [bug#60212] [PATCH] gnu: Add emacs-fzf.
Date: Tue, 20 Dec 2022 11:25:58 +0100

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fzf): New variable.

Thank you.

> +         #~(modify-phases %standard-phases
> +             (add-after 'unpack 'patch-fzf-executable
> +               (lambda* (#:key inputs #:allow-other-keys)
> +                 (make-file-writable "fzf.el")

Nitpick: The expression above is usually not necessary, even though some
package definitions use it.

> +                 (emacs-substitute-variables "fzf.el"
> +                   ("fzf/executable" (search-input-file inputs "/bin/fzf"))))))))
> +      (inputs (list fzf))
> +      (home-page "https://github.com/bling/fzf.el")
> +      (synopsis "Front-end for fzf")

I expounded it a bit.

> +      (description "An @command{emacs} front-end for @command{fzf}.")

Please write full sentences in descriptions, even if upstream does not.

Also, "@command{emacs}" conveys no more information than "Emacs". So
does "@command{fzf}" vs "Fzf". The simpler the better, IMO.

Applied!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.