GNU bug report logs - #60189
[PATCH] ert-x: Refactor `ert-with-test-buffer-selected'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Richard Hansen <rhansen <at> rhansen.org>
Subject: bug#60189: closed (Re: bug#60189: [PATCH] ert-x: Refactor
 `ert-with-test-buffer-selected')
Date: Sat, 24 Dec 2022 07:19:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#60189: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 60189 <at> debbugs.gnu.org.

-- 
60189: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60189
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 60189-done <at> debbugs.gnu.org
Subject: Re: bug#60189: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected'
Date: Sat, 24 Dec 2022 09:17:58 +0200

> Date: Mon, 19 Dec 2022 00:22:19 -0500
> From: Richard Hansen <rhansen <at> rhansen.org>
> 
> I think the attached patches can go on emacs-29 because 
> `ert-with-test-buffer-selected' was added in 29.

Thanks, installed.

[Message part 3 (message/rfc822, inline)]

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected'
Date: Mon, 19 Dec 2022 00:22:19 -0500

[Message part 4 (text/plain, inline)]

I think the attached patches can go on emacs-29 because 
`ert-with-test-buffer-selected' was added in 29.

Patch 1:

    ; ert-x: Add test for buffer read-only state

    This test should have been included with commit
    29b7d740006fe2190a729bd1c30ccab9356cee36.

Patch 2:

    ; ert-x: Simplify `ert-with-test-buffer-selected'

Patch 3:

    ert-x: Move window selection logic to its own macro

    * lisp/emacs-lisp/ert-x.el (ert-with-buffer-selected): New macro to
    temporarily display a buffer in a selected window and evaluate a body.
    (ert-with-test-buffer-selected): Use the new macro.
    * test/lisp/whitespace-tests.el (ert-test-with-buffer-selected/*): Add
    tests.

[0001-ert-x-Add-test-for-buffer-read-only-state.patch (text/x-patch, attachment)]

[0002-ert-x-Simplify-ert-with-test-buffer-selected.patch (text/x-patch, attachment)]

[0003-ert-x-Move-window-selection-logic-to-its-own-macro.patch (text/x-patch, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.