GNU bug report logs - #60189
[PATCH] ert-x: Refactor `ert-with-test-buffer-selected'

Previous Next

Package: emacs;

Reported by: Richard Hansen <rhansen <at> rhansen.org>

Date: Mon, 19 Dec 2022 05:23:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60189 in the body.
You can then email your comments to 60189 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#60189; Package emacs. (Mon, 19 Dec 2022 05:23:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Richard Hansen <rhansen <at> rhansen.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 19 Dec 2022 05:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Hansen <rhansen <at> rhansen.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected'
Date: Mon, 19 Dec 2022 00:22:19 -0500

[Message part 1 (text/plain, inline)]
I think the attached patches can go on emacs-29 because 
`ert-with-test-buffer-selected' was added in 29.

Patch 1:

    ; ert-x: Add test for buffer read-only state

    This test should have been included with commit
    29b7d740006fe2190a729bd1c30ccab9356cee36.

Patch 2:

    ; ert-x: Simplify `ert-with-test-buffer-selected'

Patch 3:

    ert-x: Move window selection logic to its own macro

    * lisp/emacs-lisp/ert-x.el (ert-with-buffer-selected): New macro to
    temporarily display a buffer in a selected window and evaluate a body.
    (ert-with-test-buffer-selected): Use the new macro.
    * test/lisp/whitespace-tests.el (ert-test-with-buffer-selected/*): Add
    tests.

[0001-ert-x-Add-test-for-buffer-read-only-state.patch (text/x-patch, attachment)]
[0002-ert-x-Simplify-ert-with-test-buffer-selected.patch (text/x-patch, attachment)]
[0003-ert-x-Move-window-selection-logic-to-its-own-macro.patch (text/x-patch, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sat, 24 Dec 2022 07:19:02 GMT) Full text and rfc822 format available.
Notification sent to Richard Hansen <rhansen <at> rhansen.org>:
bug acknowledged by developer. (Sat, 24 Dec 2022 07:19:02 GMT) Full text and rfc822 format available.

Message #10 received at 60189-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Richard Hansen <rhansen <at> rhansen.org>
Cc: 60189-done <at> debbugs.gnu.org
Subject: Re: bug#60189: [PATCH] ert-x: Refactor `ert-with-test-buffer-selected'
Date: Sat, 24 Dec 2022 09:17:58 +0200

> Date: Mon, 19 Dec 2022 00:22:19 -0500
> From: Richard Hansen <rhansen <at> rhansen.org>
> 
> I think the attached patches can go on emacs-29 because 
> `ert-with-test-buffer-selected' was added in 29.

Thanks, installed.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 21 Jan 2023 12:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 149 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.