GNU bug report logs - #60162
[PATCH] * lisp/cus-edit.el (setopt--set): Warn instead of rasing an error

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#60162: closed ([PATCH] * lisp/cus-edit.el (setopt--set): Warn
 instead of rasing an error)
Date: Sun, 18 Dec 2022 11:47:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 18 Dec 2022 11:46:36 +0000
with message-id <87v8m9x7c3.fsf <at> posteo.net>
and subject line Re: bug#60162: [PATCH] * lisp/cus-edit.el (setopt--set): Warn instead of rasing an error
has caused the debbugs.gnu.org bug report #60162,
regarding [PATCH] * lisp/cus-edit.el (setopt--set): Warn instead of rasing an error
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
60162: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60162
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] * lisp/cus-edit.el (setopt--set): Warn instead of rasing an
 error
Date: Sat, 17 Dec 2022 16:35:08 +0000

[Message part 3 (text/plain, inline)]

Tags: patch


Setopt checks the :type of a user option, and raises an user-error if
the value doesn't match the type.  This can be annoying during
initialisation, because minor mistakes interrupt everything and you are
let with a partially loaded configuration.

I'd propose replacing the `user-error' with a `warn', that would still
indicate mistakes, but continue loading the init.el.

In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal
Repository revision: 622838b957e240d700585050e9ddbd036e690513
Repository branch: emacs-29
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'

[0001-lisp-cus-edit.el-setopt-set-Warn-instead-of-rasing-a.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60162-done <at> debbugs.gnu.org
Subject: Re: bug#60162: [PATCH] * lisp/cus-edit.el (setopt--set): Warn
 instead of rasing an error
Date: Sun, 18 Dec 2022 11:46:36 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Sat, 17 Dec 2022 16:35:08 +0000
>> 
>> Setopt checks the :type of a user option, and raises an user-error if
>> the value doesn't match the type.  This can be annoying during
>> initialisation, because minor mistakes interrupt everything and you are
>> let with a partially loaded configuration.
>> 
>> I'd propose replacing the `user-error' with a `warn', that would still
>> indicate mistakes, but continue loading the init.el.
>
> This is fine by me, please install on the release branch.

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.