GNU bug report logs - #60161
[PATCH] Allow customising windmove user options with an empty prefix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60161 in the body.
You can then email your comments to 60161 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow customising windmove user options with an empty prefix
Date: Sat, 17 Dec 2022 15:04:41 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


I just switched to setopt, and noticed a few errors.  Among these was
`windmove-default-keybindings', which didn't want to set

  (setopt windmove-default-keybindings '(nil . nil))

while

  (setopt windmove-default-keybindings '("C-c" . nil))

is allowed.  The mistake appears to be that the option type is
misconfigured, and believes the car must be a keybinding, which hasn't
been the case since Emacs 28.  The patch below updates the type,
resolving this issue.

In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal
Repository revision: 622838b957e240d700585050e9ddbd036e690513
Repository branch: emacs-29
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'

[0001-Allow-customising-windmove-user-options-with-an-empt.patch (text/patch, attachment)]

Message #8 received at 60161 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60161 <at> debbugs.gnu.org
Subject: Re: bug#60161: [PATCH] Allow customising windmove user options with an
 empty prefix
Date: Sun, 18 Dec 2022 13:23:34 +0200

> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Sat, 17 Dec 2022 15:04:41 +0000
> 
> I just switched to setopt, and noticed a few errors.  Among these was
> `windmove-default-keybindings', which didn't want to set
> 
>   (setopt windmove-default-keybindings '(nil . nil))
> 
> while
> 
>   (setopt windmove-default-keybindings '("C-c" . nil))
> 
> is allowed.  The mistake appears to be that the option type is
> misconfigured, and believes the car must be a keybinding, which hasn't
> been the case since Emacs 28.  The patch below updates the type,
> resolving this issue.

Thanks, please install on the release branch.

Message #13 received at 60161-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60161-done <at> debbugs.gnu.org
Subject: Re: bug#60161: [PATCH] Allow customising windmove user options with
 an empty prefix
Date: Sun, 18 Dec 2022 11:46:29 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Sat, 17 Dec 2022 15:04:41 +0000
>> 
>> I just switched to setopt, and noticed a few errors.  Among these was
>> `windmove-default-keybindings', which didn't want to set
>> 
>>   (setopt windmove-default-keybindings '(nil . nil))
>> 
>> while
>> 
>>   (setopt windmove-default-keybindings '("C-c" . nil))
>> 
>> is allowed.  The mistake appears to be that the option type is
>> misconfigured, and believes the car must be a keybinding, which hasn't
>> been the case since Emacs 28.  The patch below updates the type,
>> resolving this issue.
>
> Thanks, please install on the release branch.

Pushed

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.