GNU bug report logs - #60161
[PATCH] Allow customising windmove user options with an empty prefix

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Subject: bug#60161: closed (Re: bug#60161: [PATCH] Allow customising
 windmove user options with an empty prefix)
Date: Sun, 18 Dec 2022 11:47:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#60161: [PATCH] Allow customising windmove user options with an empty prefix

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 60161 <at> debbugs.gnu.org.

-- 
60161: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60161
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60161-done <at> debbugs.gnu.org
Subject: Re: bug#60161: [PATCH] Allow customising windmove user options with
 an empty prefix
Date: Sun, 18 Dec 2022 11:46:29 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Sat, 17 Dec 2022 15:04:41 +0000
>> 
>> I just switched to setopt, and noticed a few errors.  Among these was
>> `windmove-default-keybindings', which didn't want to set
>> 
>>   (setopt windmove-default-keybindings '(nil . nil))
>> 
>> while
>> 
>>   (setopt windmove-default-keybindings '("C-c" . nil))
>> 
>> is allowed.  The mistake appears to be that the option type is
>> misconfigured, and believes the car must be a keybinding, which hasn't
>> been the case since Emacs 28.  The patch below updates the type,
>> resolving this issue.
>
> Thanks, please install on the release branch.

Pushed

[Message part 3 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow customising windmove user options with an empty prefix
Date: Sat, 17 Dec 2022 15:04:41 +0000

[Message part 4 (text/plain, inline)]

Tags: patch


I just switched to setopt, and noticed a few errors.  Among these was
`windmove-default-keybindings', which didn't want to set

  (setopt windmove-default-keybindings '(nil . nil))

while

  (setopt windmove-default-keybindings '("C-c" . nil))

is allowed.  The mistake appears to be that the option type is
misconfigured, and believes the car must be a keybinding, which hasn't
been the case since Emacs 28.  The patch below updates the type,
resolving this issue.

In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal
Repository revision: 622838b957e240d700585050e9ddbd036e690513
Repository branch: emacs-29
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'

[0001-Allow-customising-windmove-user-options-with-an-empt.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.