GNU bug report logs - #60130
[PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Fri, 16 Dec 2022 23:14:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: gregory <at> heytings.org, 60130 <at> debbugs.gnu.org
Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify
Date: Sat, 17 Dec 2022 11:19:46 +0000
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 60130 <at> debbugs.gnu.org
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Fri, 16 Dec 2022 23:40:37 +0000
>> 
>> Gregory Heytings <gregory <at> heytings.org> writes:
>> 
>> >>
>> >> I am not sure if I am missing something, but shouldn't the above
>> >> patch be "simpler" and more idiomatic?
>> >>
>> >
>> > Indeed.  The "progn" is a remnant of an earlier version of that code,
>> > and can safely be removed.
>> 
>> Ok, I'll push the change.
>
> Please don't install code cleanups on the release branch.
>
> I've reverted the commit on the release branch.  Please install this
> on master instead.

Sorry about that, I just cherry-picked the commit onto master. 

> Thanks.




This bug report was last modified 2 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.