GNU bug report logs - #60130
[PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60130 in the body.
You can then email your comments to 60130 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify
Date: Fri, 16 Dec 2022 23:12:58 +0000

[Message part 1 (text/plain, inline)]

Tags: patch


I am not sure if I am missing something, but shouldn't the above patch
be "simpler" and more idiomatic?


In GNU Emacs 29.0.60 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.35, cairo version 1.16.0) of 2022-12-14 built on quetzal
Repository revision: 622838b957e240d700585050e9ddbd036e690513
Repository branch: emacs-29
System Description: Debian GNU/Linux bookworm/sid

Configured using:
 'configure --with-pgtk --with-imagemagick'

[0001-lisp-subr.el-internal-with-narrowing-Simplify.patch (text/patch, attachment)]

Message #8 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing):
 Simplify
Date: Fri, 16 Dec 2022 23:31:22 +0000

>
> I am not sure if I am missing something, but shouldn't the above patch 
> be "simpler" and more idiomatic?
>

Indeed.  The "progn" is a remnant of an earlier version of that code, and 
can safely be removed.

Message #11 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing):
 Simplify
Date: Fri, 16 Dec 2022 23:40:37 +0000

Gregory Heytings <gregory <at> heytings.org> writes:

>>
>> I am not sure if I am missing something, but shouldn't the above
>> patch be "simpler" and more idiomatic?
>>
>
> Indeed.  The "progn" is a remnant of an earlier version of that code,
> and can safely be removed.

Ok, I'll push the change.

Message #16 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: gregory <at> heytings.org, 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ;
 * lisp/subr.el (internal--with-narrowing): Simplify
Date: Sat, 17 Dec 2022 09:52:49 +0200

> Cc: 60130 <at> debbugs.gnu.org
> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Fri, 16 Dec 2022 23:40:37 +0000
> 
> Gregory Heytings <gregory <at> heytings.org> writes:
> 
> >>
> >> I am not sure if I am missing something, but shouldn't the above
> >> patch be "simpler" and more idiomatic?
> >>
> >
> > Indeed.  The "progn" is a remnant of an earlier version of that code,
> > and can safely be removed.
> 
> Ok, I'll push the change.

Please don't install code cleanups on the release branch.

I've reverted the commit on the release branch.  Please install this
on master instead.

Thanks.

Message #19 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: gregory <at> heytings.org, 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing):
 Simplify
Date: Sat, 17 Dec 2022 11:19:46 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 60130 <at> debbugs.gnu.org
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Fri, 16 Dec 2022 23:40:37 +0000
>> 
>> Gregory Heytings <gregory <at> heytings.org> writes:
>> 
>> >>
>> >> I am not sure if I am missing something, but shouldn't the above
>> >> patch be "simpler" and more idiomatic?
>> >>
>> >
>> > Indeed.  The "progn" is a remnant of an earlier version of that code,
>> > and can safely be removed.
>> 
>> Ok, I'll push the change.
>
> Please don't install code cleanups on the release branch.
>
> I've reverted the commit on the release branch.  Please install this
> on master instead.

Sorry about that, I just cherry-picked the commit onto master. 

> Thanks.

Message #22 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: gregory <at> heytings.org, 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing):
 Simplify
Date: Sat, 17 Dec 2022 13:31:29 +0200

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: gregory <at> heytings.org,  60130 <at> debbugs.gnu.org
> Date: Sat, 17 Dec 2022 11:19:46 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > I've reverted the commit on the release branch.  Please install this
> > on master instead.
> 
> Sorry about that, I just cherry-picked the commit onto master. 

I hope the merge from the release branch to master will not revert
your cherry-pick.

Message #25 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: gregory <at> heytings.org, 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing):
 Simplify
Date: Sat, 17 Dec 2022 11:50:25 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Cc: gregory <at> heytings.org,  60130 <at> debbugs.gnu.org
>> Date: Sat, 17 Dec 2022 11:19:46 +0000
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > I've reverted the commit on the release branch.  Please install this
>> > on master instead.
>> 
>> Sorry about that, I just cherry-picked the commit onto master. 
>
> I hope the merge from the release branch to master will not revert
> your cherry-pick.

From my understanding of Git this shouldn't be the case (though it is an
interesting question), but if it does happen, I will try and fix that.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.