GNU bug report logs - #60130
[PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Fri, 16 Dec 2022 23:14:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


Message #16 received at 60130 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: gregory <at> heytings.org, 60130 <at> debbugs.gnu.org
Subject: Re: bug#60130: [PATCH] ;
 * lisp/subr.el (internal--with-narrowing): Simplify
Date: Sat, 17 Dec 2022 09:52:49 +0200
> Cc: 60130 <at> debbugs.gnu.org
> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Fri, 16 Dec 2022 23:40:37 +0000
> 
> Gregory Heytings <gregory <at> heytings.org> writes:
> 
> >>
> >> I am not sure if I am missing something, but shouldn't the above
> >> patch be "simpler" and more idiomatic?
> >>
> >
> > Indeed.  The "progn" is a remnant of an earlier version of that code,
> > and can safely be removed.
> 
> Ok, I'll push the change.

Please don't install code cleanups on the release branch.

I've reverted the commit on the release branch.  Please install this
on master instead.

Thanks.




This bug report was last modified 2 years and 154 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.