GNU bug report logs - #60079
[PATCH] guix: gexp: Clarify what output can be in gexp module commentary.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Thu, 15 Dec 2022 00:28:02 UTC

Severity: normal

Tags: patch, wontfix

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, jgart <jgart <at> dismail.de>
Cc: 60079 <at> debbugs.gnu.org
Subject: [bug#60079] [PATCH] guix: gexp: Clarify what output can be in gexp module commentary.
Date: Fri, 06 Jan 2023 18:31:59 +0100
Hi,

On Wed, 21 Dec 2022 at 14:31, Ludovic Courtès <ludo <at> gnu.org> wrote:

>> --- a/guix/gexp.scm
>> +++ b/guix/gexp.scm
>> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>>  ;;; This module implements "G-expressions", or "gexps".  Gexps are like
>>  ;;; S-expressions (sexps), with two differences:
>>  ;;;
>> -;;;   1. References (un-quotations) to derivations or packages in a gexp are
>> -;;;      replaced by the corresponding output file name; in addition, the
>> -;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
>> -;;;      the native code of a given package, in case of cross-compilation;
>> +;;;   1. References (un-quotations) to derivations or packages in a gexp
>> +;;;   are replaced by the corresponding output store path or file name;
>> +;;;   in addition, the 'ungexp-native' unquote-like form allows code to
>> +;;;   explicitly refer to the native code of a given package, in case
>> +;;;   of cross-compilation;
>
> I prefer not to apply this patch: it worsens indentation and adds the
> words “store path”, which AFAICS bring nothing.

I agree.  Closing?

> Thanks anyway for taking a look,

Thanks.

Cheers,
simon




This bug report was last modified 2 years and 132 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.