GNU bug report logs - #60079
[PATCH] guix: gexp: Clarify what output can be in gexp module commentary.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60079 in the body.
You can then email your comments to 60079 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>, jgart <jgart <at> dismail.de>
Subject: [PATCH] guix: gexp: Clarify what output can be in gexp module
 commentary.
Date: Wed, 14 Dec 2022 18:26:01 -0600

* guix/gexp.scm (Commentary): Clarify comment.

Hi Ludo et al,

WDYT

all best,

jgart
---
 guix/gexp.scm | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/guix/gexp.scm b/guix/gexp.scm
index 5f92174a2c..33d0d8487d 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -139,10 +139,11 @@ (define-module (guix gexp)
 ;;; This module implements "G-expressions", or "gexps".  Gexps are like
 ;;; S-expressions (sexps), with two differences:
 ;;;
-;;;   1. References (un-quotations) to derivations or packages in a gexp are
-;;;      replaced by the corresponding output file name; in addition, the
-;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
-;;;      the native code of a given package, in case of cross-compilation;
+;;;   1. References (un-quotations) to derivations or packages in a gexp
+;;;   are replaced by the corresponding output store path or file name;
+;;;   in addition, the 'ungexp-native' unquote-like form allows code to
+;;;   explicitly refer to the native code of a given package, in case
+;;;   of cross-compilation;
 ;;;
 ;;;   2. Gexps embed information about the derivations they refer to.
 ;;;
-- 
2.38.1

Message #8 received at 60079 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: jgart <jgart <at> dismail.de>
Cc: 60079 <at> debbugs.gnu.org
Subject: Re: bug#60079: [PATCH] guix: gexp: Clarify what output can be in
 gexp module commentary.
Date: Wed, 21 Dec 2022 14:31:45 +0100

Hi jgart,

jgart <jgart <at> dismail.de> skribis:

> --- a/guix/gexp.scm
> +++ b/guix/gexp.scm
> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>  ;;; This module implements "G-expressions", or "gexps".  Gexps are like
>  ;;; S-expressions (sexps), with two differences:
>  ;;;
> -;;;   1. References (un-quotations) to derivations or packages in a gexp are
> -;;;      replaced by the corresponding output file name; in addition, the
> -;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
> -;;;      the native code of a given package, in case of cross-compilation;
> +;;;   1. References (un-quotations) to derivations or packages in a gexp
> +;;;   are replaced by the corresponding output store path or file name;
> +;;;   in addition, the 'ungexp-native' unquote-like form allows code to
> +;;;   explicitly refer to the native code of a given package, in case
> +;;;   of cross-compilation;

I prefer not to apply this patch: it worsens indentation and adds the
words “store path”, which AFAICS bring nothing.

Thanks anyway for taking a look,
Ludo’.

Message #15 received at 60079 <at> debbugs.gnu.org (full text, mbox):

From: zimoun <zimon.toutoune <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>, jgart <jgart <at> dismail.de>
Cc: 60079 <at> debbugs.gnu.org
Subject: Re: [bug#60079] [PATCH] guix: gexp: Clarify what output can be in
 gexp module commentary.
Date: Fri, 06 Jan 2023 18:31:59 +0100

Hi,

On Wed, 21 Dec 2022 at 14:31, Ludovic Courtès <ludo <at> gnu.org> wrote:

>> --- a/guix/gexp.scm
>> +++ b/guix/gexp.scm
>> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>>  ;;; This module implements "G-expressions", or "gexps".  Gexps are like
>>  ;;; S-expressions (sexps), with two differences:
>>  ;;;
>> -;;;   1. References (un-quotations) to derivations or packages in a gexp are
>> -;;;      replaced by the corresponding output file name; in addition, the
>> -;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
>> -;;;      the native code of a given package, in case of cross-compilation;
>> +;;;   1. References (un-quotations) to derivations or packages in a gexp
>> +;;;   are replaced by the corresponding output store path or file name;
>> +;;;   in addition, the 'ungexp-native' unquote-like form allows code to
>> +;;;   explicitly refer to the native code of a given package, in case
>> +;;;   of cross-compilation;
>
> I prefer not to apply this patch: it worsens indentation and adds the
> words “store path”, which AFAICS bring nothing.

I agree.  Closing?

> Thanks anyway for taking a look,

Thanks.

Cheers,
simon

Message #18 received at 60079 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "zimoun" <zimon.toutoune <at> gmail.com>,
 "Ludovic Courtès" <ludo <at> gnu.org>
Cc: 60079 <at> debbugs.gnu.org
Subject: Re: [bug#60079] [PATCH] guix: gexp: Clarify what output can be in
 gexp module commentary.
Date: Fri, 06 Jan 2023 22:58:18 +0000

Sure, feel free to close this one. Thanks for the review.

all best,

jgart

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.