GNU bug report logs - #59985
30.0.50; tag error of switch-to-prev-buffer-skip-p in window.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Shuguang Sun <shuguang79 <at> qq.com>
Subject: bug#59985: closed (Re: bug#59985: 30.0.50; tag error of
 switch-to-prev-buffer-skip-p in window.el)
Date: Wed, 14 Dec 2022 15:11:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#59985: 30.0.50; tag error of switch-to-prev-buffer-skip-p in window.el

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 59985 <at> debbugs.gnu.org.

-- 
59985: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59985
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Shuguang Sun <shuguang79 <at> qq.com>
Cc: 59985-done <at> debbugs.gnu.org
Subject: Re: bug#59985: 30.0.50;
 tag error of switch-to-prev-buffer-skip-p in window.el
Date: Wed, 14 Dec 2022 17:10:30 +0200

> In `switch-to-prev-buffer-skip-p` of window.el, the tag of `found` is
> not throw but `tag`. It makes switch/delete buffer failed if set
> `switch-to-prev-buffer-skip-regexp` to a list/cons.
> 
> Below is the diff.

Thanks, installed on the emacs-29 branch, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Shuguang Sun <shuguang79 <at> qq.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; tag error of switch-to-prev-buffer-skip-p in window.el
Date: Mon, 12 Dec 2022 12:40:39 +0800

Dear all,

In `switch-to-prev-buffer-skip-p` of window.el, the tag of `found` is
not throw but `tag`. It makes switch/delete buffer failed if set
`switch-to-prev-buffer-skip-regexp` to a list/cons.

Below is the diff.

```
diff --git a/lisp/window.el b/lisp/window.el
index a11293d372a..7d8ee48635a 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -4636,7 +4636,7 @@ switch-to-prev-buffer-skip-p
                     (catch 'found
                       (dolist (regexp switch-to-prev-buffer-skip-regexp)
                         (when (string-match-p regexp (buffer-name buffer))
-                          (throw 'tag t)))))))))
+                          (throw 'found t)))))))))
 
 (defun switch-to-prev-buffer (&optional window bury-or-kill)
   "In WINDOW switch to previous buffer.
```

Best Regards,
Shuguang

In GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2022-12-11 built
 on YJ190169
Repository revision: 85108d541217f0333860c4f86c3b16b4349f85a4
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.22621
System Description: Microsoft Windows 10 Home China (v10.0.2009.22621.900)

Configured using:
 'configure --without-pop --with-native-image-api
 --with-native-compilation --with-tree-sitter --without-compress-install
 '--program-transform-name=s/^ctags$/ctags.emacs/''

Configured features:
ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES
NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.