GNU bug report logs - #59985
30.0.50; tag error of switch-to-prev-buffer-skip-p in window.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59985 in the body.
You can then email your comments to 59985 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Shuguang Sun <shuguang79 <at> qq.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; tag error of switch-to-prev-buffer-skip-p in window.el
Date: Mon, 12 Dec 2022 12:40:39 +0800

Dear all,

In `switch-to-prev-buffer-skip-p` of window.el, the tag of `found` is
not throw but `tag`. It makes switch/delete buffer failed if set
`switch-to-prev-buffer-skip-regexp` to a list/cons.

Below is the diff.

```
diff --git a/lisp/window.el b/lisp/window.el
index a11293d372a..7d8ee48635a 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -4636,7 +4636,7 @@ switch-to-prev-buffer-skip-p
                     (catch 'found
                       (dolist (regexp switch-to-prev-buffer-skip-regexp)
                         (when (string-match-p regexp (buffer-name buffer))
-                          (throw 'tag t)))))))))
+                          (throw 'found t)))))))))
 
 (defun switch-to-prev-buffer (&optional window bury-or-kill)
   "In WINDOW switch to previous buffer.
```

Best Regards,
Shuguang

In GNU Emacs 30.0.50 (build 1, x86_64-w64-mingw32) of 2022-12-11 built
 on YJ190169
Repository revision: 85108d541217f0333860c4f86c3b16b4349f85a4
Repository branch: master
Windowing system distributor 'Microsoft Corp.', version 10.0.22621
System Description: Microsoft Windows 10 Home China (v10.0.2009.22621.900)

Configured using:
 'configure --without-pop --with-native-image-api
 --with-native-compilation --with-tree-sitter --without-compress-install
 '--program-transform-name=s/^ctags$/ctags.emacs/''

Configured features:
ACL DBUS GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES
NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Message #12 received at 59985-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Shuguang Sun <shuguang79 <at> qq.com>
Cc: 59985-done <at> debbugs.gnu.org
Subject: Re: bug#59985: 30.0.50;
 tag error of switch-to-prev-buffer-skip-p in window.el
Date: Wed, 14 Dec 2022 17:10:30 +0200

> In `switch-to-prev-buffer-skip-p` of window.el, the tag of `found` is
> not throw but `tag`. It makes switch/delete buffer failed if set
> `switch-to-prev-buffer-skip-regexp` to a list/cons.
> 
> Below is the diff.

Thanks, installed on the emacs-29 branch, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.