GNU bug report logs - #5997
vhdl-comment-uncomment-region

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5997 in the body.
You can then email your comments to 5997 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jerzy Gbur <jerzy.gbur <at> gmail.com>
To: bug-emacs <at> gnu.org
Subject: migration emacs 22.3 to 23.1
Date: Wed, 21 Apr 2010 15:42:30 +0200

Hi
I use emacs for VHDL (vhdl-mode) coding mostly.
After I updated emacs from version 22.3 to 23.1 have problem with
vhdl-comment-uncomment-region function.

Earlier I marked region and did \C-c \C-c, and region was commented or
uncommented. Comment marks '--' were placed on the first column no
matter where code text were started.

In this version (23.1) comment marks are inserted just before code
text without any spaces, and vhdl-comment-uncomment-region function
doesn't know that this row is commented or no, so it makes new comment
and so on....

Regards,

Jerzy Gbur

Message #10 received at 5997 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jerzy Gbur <jerzy.gbur <at> gmail.com>
Cc: 5997 <at> debbugs.gnu.org
Subject: Re: bug#5997: migration emacs 22.3 to 23.1
Date: Thu, 22 Apr 2010 09:39:03 -0400

> In this version (23.1) comment marks are inserted just before code
> text without any spaces,

This is probably because vhdl-comment-uncomment-region uses
comment-region, whose default behavior was changed.  See comment-style.

> and vhdl-comment-uncomment-region function doesn't know that this row
> is commented or no, so it makes new comment and so on....

Rather than C-c C-c (which is specific to VHDL) you may want to try M-;
which should work in "any" mode.  This is use comment-region and
uncomment-region.  I can't seem to reproduce your bug with M-;, so that
would seem to indicate that the bug is in vhdl-comment-uncomment-region,
but please try it out and if you can reproduce it with M-; give us
a precise recipe (and if not tell us so as well, so we know where to
find the fix).


        Stefan

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#5997: migration emacs 22.3 to 23.1
Date: Thu, 22 Apr 2010 16:56:49 +0100

On 2010-04-22 14:39 +0100, Stefan Monnier wrote:
>> and vhdl-comment-uncomment-region function doesn't know that this row
>> is commented or no, so it makes new comment and so on....
>
> Rather than C-c C-c (which is specific to VHDL) you may want to try M-;
> which should work in "any" mode.

I always hate it when a mode overrides a global binding for no good
reason. It gives surprises on the first use. There are quite a few in
Emacs, unfortunately. To name a few:

1. diff-mode binds M-q
2. M-s that was used to search history is overwritten by the new M-s
   prefix. See for example in ielm.
3. Winner mode key bindings are active in minibuffer which makes ido
   fail to perform some of its functions.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.