GNU bug report logs - #59935
29.0.60; project-list-buffers is slow

Previous Next

Full log

Message #41 received at 59935 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 59935 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: Re: bug#59935: 29.0.60; project-list-buffers is slow
Date: Sat, 10 Dec 2022 22:11:13 +0200

> Date: Sat, 10 Dec 2022 21:53:28 +0200
> Cc: 59935 <at> debbugs.gnu.org, juri <at> linkov.net
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> 
> On 10/12/2022 21:42, Eli Zaretskii wrote:
> >> Date: Sat, 10 Dec 2022 21:19:30 +0200
> >> Cc:59935 <at> debbugs.gnu.org,juri <at> linkov.net
> >> From: Dmitry Gutov<dgutov <at> yandex.ru>
> >>
> >> On 10/12/2022 16:33, Eli Zaretskii wrote:
> >>> OK, but I didn't suggest making any changes to revert-buffer-function
> >>> set up by "C-x p C-b".  You can still use process-buffers there, and
> >>> it shouldn't slow down "C-x p C-b" itself, since the call to
> >>> process-buffers that is part of revert-buffer-function is not supposed
> >>> to be evaluated when you set revert-buffer-function.  Right?  Or what
> >>> else am I missing?
> >> Then only the 'g' binding will remain slow. An improvement, of course.
> > Why slow? it calls project-buffers only once.
> 
> You're looking at the "legacy" code path. Where emacs-version is < 29.

I'm looking at the code you posted as the original one, which is
identical to what I see on the current emacs-29 branch.  That means
Emacs 29, unless I'm seriously confused.

> In the "new" one revert-buffer-function uses the filter-predicate 
> argument we pass to list-buffers-noselect. Which is
> 
>    (lambda (buf) (memq buf (project-buffers pr)))

I see this in emacs-29:

             (setq-local revert-buffer-function
                         (lambda (&rest _ignored)
                           (list-buffers--refresh (project-buffers pr))
                           (tabulated-list-print t))))

So I still don't understand your fears.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.