GNU bug report logs - #59934
28.2; Doc strings of `(kill|delete)-matching-lines'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59934 in the body.
You can then email your comments to 59934 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 28.2; Doc strings of `(kill|delete)-matching-lines'
Date: Fri, 9 Dec 2022 22:51:02 +0000

These two doc strings are _very_ similar.  The two commands are
presumably nearly the same, the difference being that one kills
to the `kill-ring' and the other just deletes.

Please consider, in each of these doc strings, adding a reference to the
other command.  E.g., "See also `<other>-matching-lines', which is
similar but <summarize the difference>."  That will make uses aware of
the existence of the other command.  Sometimes users don't consider, or
aren't even aware, of the difference between the two kinds of deletion.

You might also explicitly point out the use case for `kill-*', e.g.,
when giving the summary in the "See also": killing lets you subsequently
yank the matching lines somewhere.  Doesn't hurt to point this out
briefly.

In GNU Emacs 28.2 (build 2, x86_64-w64-mingw32)
 of 2022-09-13 built on AVALON
Windowing system distributor 'Microsoft Corp.', version 10.0.19044
System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2251)

Configured using:
 'configure --with-modules --without-dbus --with-native-compilation
 --without-compress-install CFLAGS=-O2'

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
XPM ZLIB

(NATIVE_COMP present but libgccjit not available)

Message #8 received at 59934 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 59934 <at> debbugs.gnu.org
Subject: Re: bug#59934: 28.2; Doc strings of `(kill|delete)-matching-lines'
Date: Sat, 10 Dec 2022 00:01:04 +0100

[Message part 1 (text/plain, inline)]

The docstring of `kill-matching-lines' already says (just at the end):

  If you merely want to delete the lines, without adding them to
  the kill ring, the M-x flush-lines command is faster.

but the one for `delete-matching-lines'/`flush-lines' does not mention the
kill- version.

On Fri, Dec 9, 2022 at 11:52 PM Drew Adams <drew.adams <at> oracle.com> wrote:

> These two doc strings are _very_ similar.  The two commands are
> presumably nearly the same, the difference being that one kills
> to the `kill-ring' and the other just deletes.
>
> Please consider, in each of these doc strings, adding a reference to the
> other command.  E.g., "See also `<other>-matching-lines', which is
> similar but <summarize the difference>."  That will make uses aware of
> the existence of the other command.  Sometimes users don't consider, or
> aren't even aware, of the difference between the two kinds of deletion.
>
> You might also explicitly point out the use case for `kill-*', e.g.,
> when giving the summary in the "See also": killing lets you subsequently
> yank the matching lines somewhere.  Doesn't hurt to point this out
> briefly.
>
> In GNU Emacs 28.2 (build 2, x86_64-w64-mingw32)
>  of 2022-09-13 built on AVALON
> Windowing system distributor 'Microsoft Corp.', version 10.0.19044
> System Description: Microsoft Windows 10 Pro (v10.0.2009.19044.2251)
>
> Configured using:
>  'configure --with-modules --without-dbus --with-native-compilation
>  --without-compress-install CFLAGS=-O2'
>
> Configured features:
> ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP
> NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS
> XPM ZLIB
>
> (NATIVE_COMP present but libgccjit not available)
>
>
>
>
>

[Message part 2 (text/html, inline)]

Message #11 received at 59934 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: "59934 <at> debbugs.gnu.org" <59934 <at> debbugs.gnu.org>
Subject: RE: [External] : Re: bug#59934: 28.2; Doc strings of
 `(kill|delete)-matching-lines'
Date: Fri, 9 Dec 2022 23:14:30 +0000

[Message part 1 (text/plain, inline)]

The docstring of `kill-matching-lines' already says (just at the end):

  If you merely want to delete the lines, without adding them to
  the kill ring, the M-x flush-lines command is faster.

True. What's missing there is the name correspondence/similarity.
I think it would be more helpful if it used `M-x delete-matching-lines'.
Following that link, a user would see that the other name for that is `flush-lines'.

but the one for `delete-matching-lines'/`flush-lines' does not mention the kill- version.

Yup. Wouldn't hurt. No reason to copy to `kill-ring' if that's not really what you want. And some users might not realize the difference.

[Message part 2 (text/html, inline)]

Message #14 received at 59934 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Juanma Barranquero <lekktu <at> gmail.com>,
 "59934 <at> debbugs.gnu.org" <59934 <at> debbugs.gnu.org>
Subject: Re: bug#59934: 28.2; Doc strings of `(kill|delete)-matching-lines'
Date: Mon, 12 Dec 2022 16:48:48 -0800

close 59934 29.1
thanks

Drew Adams <drew.adams <at> oracle.com> writes:

> The docstring of `kill-matching-lines' already says (just at the end):
>
>   If you merely want to delete the lines, without adding them to
>   the kill ring, the M-x flush-lines command is faster.
>
> True. What's missing there is the name correspondence/similarity.
> I think it would be more helpful if it used `M-x delete-matching-lines'.
> Following that link, a user would see that the other name for that is `flush-lines'.
> but the one for `delete-matching-lines'/`flush-lines' does not mention the kill- version.

Thanks, I fixed that on emacs-29 (commit 489bcacc7c).

Message #19 received at 59934 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Juanma Barranquero <lekktu <at> gmail.com>,
 "59934 <at> debbugs.gnu.org" <59934 <at> debbugs.gnu.org>
Subject: Re: bug#59934: 28.2; Doc strings of `(kill|delete)-matching-lines'
Date: Mon, 12 Dec 2022 17:20:26 -0800

close 59934 29.1
thanks

Drew Adams <drew.adams <at> oracle.com> writes:

> The docstring of `kill-matching-lines' already says (just at the end):
>
>   If you merely want to delete the lines, without adding them to
>   the kill ring, the M-x flush-lines command is faster.
>
> True. What's missing there is the name correspondence/similarity.
> I think it would be more helpful if it used `M-x delete-matching-lines'.
> Following that link, a user would see that the other name for that is `flush-lines'.
> but the one for `delete-matching-lines'/`flush-lines' does not mention the kill- version.

Thanks, I fixed that on emacs-29 (commit 489bcacc7c).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.