GNU bug report logs - #59758
[PATCH] gnu: Add dislocker.

Previous Next

Full log

Message #8 received at 59758 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 59758 <at> debbugs.gnu.org
Subject: Re: bug#59758: [PATCH] gnu: Add dislocker.
Date: Sun, 08 Jan 2023 12:10:22 +0100

Hi,

phodina <phodina <at> protonmail.com> skribis:

> From d237aca245c0868df016ffa9ac49b7b3f1af11cc Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Thu, 13 Jan 2022 13:24:23 +0100
> Subject: [PATCH] gnu: Add dislocker.
>
> * gnu/packages/linux.scm (dislocker): New variable.
> +    (version "0.7.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               "https://github.com/Aorimn/dislocker/archive/refs/tags/v0.7.3.tar.gz")

This auto-generated tarball changes over time, as reported by ‘guix
lint’.  Could you use ‘git-fetch’ instead?

> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f))

Please avoid disabling tests.  If you really have to, add a short
comment explaining why it has to be disabled.

> +    (synopsis "FUSE driver to read/write Windows BitLocker drives")
> +    (description
> +     "This package provides means to to read BitLocker encrypted
> +         partitions. Write functionality is also provided but check the README.")

Indentation is off.  :-)

Could you send an updated patch?

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.