GNU bug report logs - #59758
[PATCH] gnu: Add dislocker.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59758 in the body.
You can then email your comments to 59758 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add dislocker.
Date: Fri, 02 Dec 2022 04:52:53 +0000

[Message part 1 (text/plain, inline)]

Hi,

here's a tool that allows you to access Bitlocker using Fuse.

----
Petr

[Message part 2 (text/html, inline)]

[0001-gnu-Add-dislocker.patch (text/x-patch, attachment)]

Message #8 received at 59758 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 59758 <at> debbugs.gnu.org
Subject: Re: bug#59758: [PATCH] gnu: Add dislocker.
Date: Sun, 08 Jan 2023 12:10:22 +0100

Hi,

phodina <phodina <at> protonmail.com> skribis:

> From d237aca245c0868df016ffa9ac49b7b3f1af11cc Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Thu, 13 Jan 2022 13:24:23 +0100
> Subject: [PATCH] gnu: Add dislocker.
>
> * gnu/packages/linux.scm (dislocker): New variable.
> +    (version "0.7.3")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               "https://github.com/Aorimn/dislocker/archive/refs/tags/v0.7.3.tar.gz")

This auto-generated tarball changes over time, as reported by ‘guix
lint’.  Could you use ‘git-fetch’ instead?

> +    (build-system cmake-build-system)
> +    (arguments '(#:tests? #f))

Please avoid disabling tests.  If you really have to, add a short
comment explaining why it has to be disabled.

> +    (synopsis "FUSE driver to read/write Windows BitLocker drives")
> +    (description
> +     "This package provides means to to read BitLocker encrypted
> +         partitions. Write functionality is also provided but check the README.")

Indentation is off.  :-)

Could you send an updated patch?

Thanks,
Ludo’.

Message #11 received at 59758 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 59758 <at> debbugs.gnu.org
Subject: Re: bug#59758: [PATCH] gnu: Add dislocker.
Date: Sun, 08 Jan 2023 23:57:05 +0000

[Message part 1 (text/plain, inline)]

Hi Ludo’,

again thanks for the review and check the updated patch.


----
Petr

[v2-0001-gnu-Add-dislocker.patch (text/x-patch, attachment)]

Message #14 received at 59758 <at> debbugs.gnu.org (full text, mbox):

From: phodina <phodina <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 59758 <at> debbugs.gnu.org
Subject: Re: bug#59758: [PATCH] gnu: Add dislocker.
Date: Mon, 09 Jan 2023 00:00:47 +0000

[Message part 1 (text/plain, inline)]

Sorry,

my mistake. That one was generated before I did git `commit --amend`.

Here's the correct one.

----
Petr

[v2-0001-gnu-Add-dislocker.patch (text/x-patch, attachment)]

Message #19 received at 59758-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: phodina <phodina <at> protonmail.com>
Cc: 59758-done <at> debbugs.gnu.org
Subject: Re: bug#59758: [PATCH] gnu: Add dislocker.
Date: Thu, 12 Jan 2023 23:33:10 +0100

phodina <phodina <at> protonmail.com> skribis:

> From 0c4e34470490f4e4e1c3ee9f7239d0ce09fea81a Mon Sep 17 00:00:00 2001
> From: Petr Hodina <phodina <at> protonmail.com>
> Date: Thu, 13 Jan 2022 13:24:23 +0100
> Subject: [PATCH v2] gnu: Add dislocker.
>
> * gnu/packages/linux.scm (dislocker): New variable.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.