GNU bug report logs - #59603
28.1.90; `ucs-normalize-string' fails to work

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ihor Radchenko <yantar92 <at> posteo.net>
Cc: 59603 <at> debbugs.gnu.org
Subject: bug#59603: 28.1.90; `ucs-normalize-string' fails to work
Date: Sat, 26 Nov 2022 11:23:51 +0200

> From: Ihor Radchenko <yantar92 <at> posteo.net>
> Cc: 59603-done <at> debbugs.gnu.org
> Date: Sat, 26 Nov 2022 09:04:22 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> (defmacro ucs-normalize-string (ucs-normalize-region)
> >>   `(with-temp-buffer
> >>      (insert str)
> >>      (,ucs-normalize-region (point-min) (point-max))
> >>      (buffer-string)))
> >> 
> >> It apparently uses undefined variable `str', which does not look right.
> >
> > It's a macro, not a function.  So STR could come from the code which calls
> > the macro.  Look how it is used in that file, and you will see what I mean.
> 
> I understand. But this macro is not private (no --). I feel like using
> "str" there is a questionable code style.

It's too late to change that: this macro is very old and predates the --
conventions.

> >> Also, no docstring.
> >
> > I added a doc string.
> 
> Thanks! The new docstring implies that STR is an argument, doesn't it?

It doesn't.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.