GNU bug report logs - #59602
29.0.50; csharp-mode should either be a package, or compat code could be removed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59602 in the body.
You can then email your comments to 59602 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; csharp-mode should either be a package, or compat code could
 be removed
Date: Sat, 26 Nov 2022 00:14:04 -0800

Severity: wishlist

Is csharp-mode.el intended to be a :core package or should people just
use the version that comes with Emacs?

If the former, I guess some Version and Package-Requires headers
are needed.

If the latter, the compat code starting on line 512 could probably be
removed.

Message #8 received at 59602 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Stefan Kangas <stefankangas <at> gmail.com>, 59602 <at> debbugs.gnu.org
Cc: Jostein Kjønigsen <jostein <at> kjonigsen.net>
Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or
 compat code could be removed
Date: Sat, 26 Nov 2022 20:12:58 +0100

[Message part 1 (text/plain, inline)]

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Severity: wishlist
>
> Is csharp-mode.el intended to be a :core package or should people just
> use the version that comes with Emacs?
>
> If the former, I guess some Version and Package-Requires headers
> are needed.
>
> If the latter, the compat code starting on line 512 could probably be
> removed.

I agree.  The compat code should be removed.  I don't thing we have much
to gain by maintaining this as a :core package, so here's a patch doing
what you suggest.  I don't think that code should be part of Emacs at
all, if not absolutely necessary :-)

Theo

[0001-Remove-compatibility-code-in-csharp-mode.patch (text/x-diff, attachment)]

Message #13 received at 59602 <at> debbugs.gnu.org (full text, mbox):

From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
To: Theodor Thornhill <theo <at> thornhill.no>,
 Stefan Kangas <stefankangas <at> gmail.com>, 59602 <at> debbugs.gnu.org,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or
 compat code could be removed
Date: Sat, 26 Nov 2022 21:58:35 +0100

[Message part 1 (text/plain, inline)]

This may be a bit "on the side", but if me and Theodor are going to be 
maintaining csharp-mode in Emacs core, we currently face the slight 
"challenge" of not actually having write/push-access to the Emacs 
git-repo at savannah.

That means that at top of our ability, we will be able to email in 
patches (like Theodor did now!) and hope for someone to review and/or 
merge them.

While don't expect that providing for unlimited git-access out of the 
blue probably is how new major-modes are taken in, I'm also not sure 
what the "normal" procedure is in cases like this.

Are there someone particular we are recommended to CC in our emails to 
make sure the patches get picked up efficiently? And what if it's not a 
registered "bug" yet, but just an improvement? Should we send it to 
emacs-devel instead?

In short: Do you guys have any "onboarding guide" we can follow to make 
sure everyone is happy, and our patches get reviewed and applied 
efficiently? :)

Any guidance appreciated!

--
Kind regards
*Jostein Kjønigsen*

jostein <at> kjonigsen.net 🍵 jostein <at> gmail.com
https://jostein.kjønigsen.no <https://jostein.kjønigsen.no>
On 26.11.2022 20:12, Theodor Thornhill wrote:
> Stefan Kangas<stefankangas <at> gmail.com>  writes:
>
>> Severity: wishlist
>>
>> Is csharp-mode.el intended to be a :core package or should people just
>> use the version that comes with Emacs?
>>
>> If the former, I guess some Version and Package-Requires headers
>> are needed.
>>
>> If the latter, the compat code starting on line 512 could probably be
>> removed.
> I agree.  The compat code should be removed.  I don't thing we have much
> to gain by maintaining this as a :core package, so here's a patch doing
> what you suggest.  I don't think that code should be part of Emacs at
> all, if not absolutely necessary :-)
>
> Theo
>

[Message part 2 (text/html, inline)]

Message #16 received at 59602 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: jostein <at> kjonigsen.net
Cc: 59602 <at> debbugs.gnu.org, theo <at> thornhill.no, stefankangas <at> gmail.com
Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or
 compat code could be removed
Date: Sun, 27 Nov 2022 08:04:07 +0200

> Date: Sat, 26 Nov 2022 21:58:35 +0100
> From: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
> 
> While don't expect that providing for unlimited git-access out of the blue probably is how new major-modes
> are taken in, I'm also not sure what the "normal" procedure is in cases like this.

The "normal" procedure is to keep posting patches for review until you feel
you've been doing that long enough, and managed to get to the state where
your patches get only minor review comments, especially about coding and
documentation conventions.  Then request write access.

> Are there someone particular we are recommended to CC in our emails to make sure the patches get
> picked up efficiently? And what if it's not a registered "bug" yet, but just an improvement? Should we send it
> to emacs-devel instead?

It is always best to use report-emacs-bug for sending patches, even if it
isn't a bug.  debbugs is our issue tracker, not just bug tracker.
emacs-devel is for discussing ideas and asking questions (you can also post
diffs to better explain what you mean or if the question is about a
particular code).

TIA

Message #21 received at 59602-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59602-done <at> debbugs.gnu.org,
 Jostein Kjønigsen <jostein <at> kjonigsen.net>
Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or
 compat code could be removed
Date: Sun, 27 Nov 2022 01:38:44 -0800

Theodor Thornhill <theo <at> thornhill.no> writes:

> I agree.  The compat code should be removed.  I don't thing we have much
> to gain by maintaining this as a :core package, so here's a patch doing
> what you suggest.  I don't think that code should be part of Emacs at
> all, if not absolutely necessary :-)

Thanks, since both you and Jostein seems to agree, I've pushed this
change (commit ea2f2f1e71).  I'm therefore closing this bug report.

Message #24 received at 59602-done <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 59602-done <at> debbugs.gnu.org,
 Jostein Kjønigsen <jostein <at> kjonigsen.net>
Subject: Re: bug#59602: 29.0.50; csharp-mode should either be a package, or compat code could be removed
Date: Sun, 27 Nov 2022 10:58:48 +0100

On 27 November 2022 10:38:44 CET, Stefan Kangas <stefankangas <at> gmail.com> wrote:
>Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> I agree.  The compat code should be removed.  I don't thing we have much
>> to gain by maintaining this as a :core package, so here's a patch doing
>> what you suggest.  I don't think that code should be part of Emacs at
>> all, if not absolutely necessary :-)
>
>Thanks, since both you and Jostein seems to agree, I've pushed this
>change (commit ea2f2f1e71).  I'm therefore closing this bug report.

Thanks, appreciate it :)

Theo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.